Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request parameters to AMQPStreamConnection out of order #60

Closed
jwkblades opened this issue Apr 10, 2019 · 3 comments
Closed

Request parameters to AMQPStreamConnection out of order #60

jwkblades opened this issue Apr 10, 2019 · 3 comments

Comments

@jwkblades
Copy link
Contributor

The context argument should be parameter 12, not 11, for the AMQPStreamConnection, which results in an exception ErrorException: stream_socket_client() expects parameter 6 to be resource, boolean given.

Looks like it should just be getting the arguments in the correct order.
@stevenklar stevenklar mentioned this issue Apr 11, 2019
Merged
stevenklar added a commit that referenced this issue Apr 11, 2019
@stevenklar
Merge pull request #61 from jwkblades/master
8237cf3 
#60 Re-order AMQPStreamConnection ctor args
@stevenklar
Copy link
Collaborator

@jwkblades This issue should be fixed with the next release of your merged PR, right?

@jwkblades
Copy link
Contributor Author

Yes, this should be resolved in the next release after my PR.

@stevenklar
Copy link
Collaborator

Released with tag 2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevenklar @jwkblades