Skip to content

Commit

Permalink
Add PNP info to PCI attachment of bktr driver
Browse files Browse the repository at this point in the history
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #5
  • Loading branch information
lakhanshiva authored and bsdimp committed Jul 8, 2018
1 parent cc00b45 commit 7d6b55c
Showing 1 changed file with 29 additions and 1 deletion.
30 changes: 29 additions & 1 deletion sys/dev/bktr/bktr_os.c
Expand Up @@ -211,6 +211,25 @@ static int bktr_detach( device_t dev );
static int bktr_shutdown( device_t dev );
static void bktr_intr(void *arg) { common_bktr_intr(arg); }

static struct bktr_dev {
uint16_t vendorid;
uint16_t deviceid;
uint8_t rev;
const char *description;
} bktr_devs[] = {
{PCI_VENDOR_BROOKTREE, PCI_PRODUCT_BROOKTREE_BT848, 0x12,
"BrookTree 848A"},
{PCI_VENDOR_BROOKTREE, PCI_PRODUCT_BROOKTREE_BT848, 0,
"BrookTree 848"},
{PCI_VENDOR_BROOKTREE, PCI_PRODUCT_BROOKTREE_BT849, 0,
"BrookTree 849A"},
{PCI_VENDOR_BROOKTREE, PCI_PRODUCT_BROOKTREE_BT878, 0,
"BrookTree 878"},
{PCI_VENDOR_BROOKTREE, PCI_PRODUCT_BROOKTREE_BT879, 0,
"BrookTree 879"},
{0, 0, 0, NULL},
};

static device_method_t bktr_methods[] = {
/* Device interface */
DEVMETHOD(device_probe, bktr_probe),
Expand Down Expand Up @@ -274,6 +293,8 @@ MODULE_DEPEND(bktr, iicbus, IICBUS_MINVER, IICBUS_MODVER, IICBUS_MAXVER);
MODULE_DEPEND(bktr, smbus, SMBUS_MINVER, SMBUS_MODVER, SMBUS_MAXVER);
#endif
DRIVER_MODULE(bktr, pci, bktr_driver, bktr_devclass, 0, 0);
MODULE_PNP_INFO("U16:vendor;U16:device", pci, bktr, bktr_devs,
sizeof(bktr_devs[0]), nitems(bktr_devs) - 1);
MODULE_DEPEND(bktr, bktr_mem, 1,1,1);
MODULE_VERSION(bktr, 1);

Expand All @@ -286,7 +307,15 @@ bktr_probe( device_t dev )
{
unsigned int type = pci_get_devid(dev);
unsigned int rev = pci_get_revid(dev);
const struct bktr_dev *bktd;
uint16_t vid;
uint16_t did;
size_t i;

vid = PCI_VENDOR(type);
did = PCI_PRODUCT(type);

// XXX merge conflicts. Need to convert to PCI_MATCH instead.
if (BKTR_PCI_VENDOR(type) == PCI_VENDOR_BROOKTREE)
{
switch (BKTR_PCI_PRODUCT(type)) {
Expand All @@ -307,7 +336,6 @@ bktr_probe( device_t dev )
return BUS_PROBE_DEFAULT;
}
}

return ENXIO;
}

Expand Down

0 comments on commit 7d6b55c

Please sign in to comment.