Add PNP info to PCI attachment of cas, ena, cy, esp, bktr, cxgb, fxp, gem, glxsb, grackle_hb, hme drivers

[lakhanshiva]

The device id table for cas is

static const struct cas_pci_dev {
	uint32_t	cpd_devid;
	uint8_t		cpd_revid;
	int		cpd_variant;
	const char	*cpd_desc;
} cas_pci_devlist[];

Therefore i used "W32:vendor/device" as descriptor string in MODULE_PNP_INFO

The device id table for ena is

typedef struct _ena_vendor_info_t {
	uint16_t vendor_id;
	uint16_t device_id;
 	unsigned int index;
 } ena_vendor_info_t;

Therefore i used "U16:vendor; U16:device" as descriptor string in MODULE_PNP_INFO

The device id table for cy is

static struct cy_dev {
	uint32_t deviceid;
	const char *description;
} cy_devs[]

Therefore i used "U32:device" as descriptor string in MODULE_PNP_INFO

The device id table for esp is

static struct esp_dev {
	uint32_t deviceid;
	const char *description;
} esp_devs[]

Therefore i used "U32:device" as descriptor string in MODULE_PNP_INFO

The device id table for bktr is

static struct bktr_dev {
	uint16_t vendorid;
	uint16_t deviceid;
	uint8_t rev;
	const char *description;
} bktr_devs[]

Therefore i used "U16:vendor;U16:device" as descriptor string in MODULE_PNP_INFO

The device id table for cxgb is

struct cxgb_ident {
	uint16_t	vendor;
	uint16_t	device;
	int		index;
	char		*desc;
} cxgb_identifiers[]

Therefore i used "U16:vendor;U16:device" as descriptor string in MODULE_PNP_INFO

The device id table for fxp is

struct fxp_ident {
	uint16_t	vendor;
	uint16_t	device;
	int16_t		revid;		/* -1 matches anything */
	uint8_t		ich;
	const char	*name;
};

Therefore i used "U16:vendor;U16:device" as descriptor string in MODULE_PNP_INFO

The device id table for gem is

static const struct gem_pci_dev {
	uint32_t	gpd_devid;
	int		gpd_variant;
	const char	*gpd_desc;
} gem_pci_devlist[]

Therefore i used "U32:device" as descriptor string in MODULE_PNP_INFO

The device id table for glxsb is

static struct glxsb_dev{
	uint16_t vendorid;
	uint16_t deviceid;
	const char *description;
} glxsb_devs[]

Therefore i used "U16:vendor;U16:device" as descriptor string in MODULE_PNP_INFO

The device id table for grackle_hb is

static struct grackle_hb_dev {
	uint32_t deviceid;
	const char *description;
} grackle_hb_devs[]

Therefore i used "U32:device" as descriptor string in MODULE_PNP_INFO

The device id table for hme is

static struct hme_dev{
	uint16_t vendorid;
	uint16_t deviceid;
	const char *description;
} hme_devs[]

Therefore i used "U16:vendor;U16:device" as descriptor string in MODULE_PNP_INFO

[ctuffli]

unsigned int is not necessarily the same size as uint16_t. Is this ok?

[lakhanshiva]

Supported PCI vendor and device id's fit into a uint16_t

/*
 * Supported PCI vendor and devices IDs
 */
#define	PCI_VENDOR_ID_AMAZON	0x1d0f

#define	PCI_DEV_ID_ENA_PF	0x0ec2
#define	PCI_DEV_ID_ENA_LLQ_PF	0x1ec2
#define	PCI_DEV_ID_ENA_VF	0xec20
#define	PCI_DEV_ID_ENA_LLQ_VF	0xec21

Even in ena_probe, it is being compared to a uint16_t type..

static int
ena_probe(device_t dev)
{
	ena_vendor_info_t *ent;
	char		adapter_name[60];
	uint16_t	pci_vendor_id = 0;
	uint16_t	pci_device_id = 0;

	pci_vendor_id = pci_get_vendor(dev);
	pci_device_id = pci_get_device(dev);

	ent = ena_vendor_info_array;
	while (ent->vendor_id != 0) {
		if ((pci_vendor_id == ent->vendor_id) &&
		    (pci_device_id == ent->device_id))

So i think this is the appropriate type for this..

[ctuffli]

After a review with @bsdimp , I'm ok with this change