Use unique epaira interface names

[grembo]

This changes the code to rename the epaira side of interfaces to a unique value and stores it in the status file.

This has multiple advantages:

• Removing the wrong interface highly unlikely
• No need to poke into the running (or potentially dying) pot when stopping

Note that dual stack isn't covered yet (wasn't with the previous either).

[grembo]

@pizzamig This is what this looks like

[root@host ~]# pot start cloneme
===>  Starting the pot cloneme
add net default: gateway 10.192.0.1
[root@host ~]# cat /tmp/pot_status_cloneme 
pot.status=started,p4632611c512510
[root@host ~]# ifconfig p4632611c512510
p4632611c512510: flags=8963<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> metric 0 mtu 1500
	description: cloneme
	options=8<VLAN_MTU>
	ether 02:ca:3c:ac:ce:0a
	groups: epair pot
	media: Ethernet 10Gbase-T (10Gbase-T <full-duplex>)
	status: active
	nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
[root@host ~]# pot stop cloneme
[root@host ~]#

[grembo]

Dual stack example in action:

[root@host ~]# pot start -v cloneme
=====>  mount /opt/pot/jails/cloneme/m/tmp
===>  Starting the pot cloneme
add net default: gateway 10.192.0.1
rtsol: No answer after sending 3 RSs
[root@host ~]# pot stop -v cloneme
=====>  Stop the pot cloneme
=====>  Remove p4632706721649 epair network interfaces
=====>  Remove p6632706721649 epair network interfaces
=====>  unmount /opt/pot/jails/cloneme/m/tmp
=====>  unmount /opt/pot/jails/cloneme/m/dev

[pizzamig]

small comments only

[pizzamig]

@grembo Where are we with this?

[grembo]

@grembo Where are we with this?

on vacation, but I can look into it soon

[pizzamig]

No rush, when you are back! Enjoy your time off!

[grembo]

@pizzamig Did some basic tests after the latest change to confirm it still works (having some basic automatic tests would be great).

[pizzamig]

In tests/CI there is a run.sh script, that perform a set of operation, using multiple configurations.
It was designed to run in an empty VM, with no pots (to easily check if all pots have been correctly destroyed after tests).
I will test this branch with this script later

[grembo]

In tests/CI there is a run.sh script, that perform a set of operation, using multiple configurations. It was designed to run in an empty VM, with no pots (to easily check if all pots have been correctly destroyed after tests). I will test this branch with this script later

I implemented some pot testing for the FreeBSD sccache-dist patch (PR still pending): https://github.com/mozilla/sccache/pull/1184/files

I could adapt that to run these tests using github actions.

[grembo]

@pizzamig I created #236 which allows us to run CI tests as a github action. Once this lands (and ci.yml is part of the master branch), I will rebase this issue and we can run the integration tests manually in github actions.

[grembo]

@pizzamig Successful CI run: https://github.com/grembo/pot/actions/runs/3308124096