Github CI action, fix pot destroy leftovers #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly improve CI script (e.g., detect IPv6 missing), add github CI action (triggers on push to the branch and should be able to be run manually once it lands in master). Pot destroy left directories behind on destroy (side-effect of the previous partially reverted commit, but could also happen in other ways, hence the explicit fix).
grembo
force-pushed
the
github-ci-action
branch
from
f981670
to
e569a3c
Compare
|
See here for an example run (on push for the special branch), I hope you can see it: https://github.com/grembo/pot/actions/runs/3295824125/jobs/5434775436 |
pizzamig
approved these changes
Oct 23, 2022
| @@ -61,6 +61,10 @@ _pot_zfs_destroy() | |||
| _error "zfs failed to destroy the dataset $_jdset" | |||
| return 1 # false | |||
| fi | |||
| if [ -d "${POT_FS_ROOT}/jails/$_pname" ]; then | |||
There was a problem hiding this comment.
While probably it's a good idea to have those kind of robust clean-up features, we should aim to not depend on them for "normal" use cases.
I started a patch to fix the cases we introduced that broke destroy, I'll submit it later.
There was a problem hiding this comment.
Yeah, basically rolling back the commit that introduced the mkdir wrapper, that was a good example of failing in a team 😁
I'll start working on the real solution to the permission issue like discussed soonish (essentially chmod 750 /opt/pot; chown root:pot /opt/pot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly improve CI script (e.g., detect IPv6 missing), add github CI action (triggers on push to the branch and should be able to be run manually once it lands in master). As running it is quite expensive, I wouldn't run it automatically at the moment. The idea is to have the CI workflow in github actions, so we can run it before cutting a release.
Pot destroy left directories behind on destroy (side-effect of the previous partially reverted commit, but could also happen in other ways, hence the explicit fix by removing those directores).