Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in listener refreshPosition() #19

Merged
merged 1 commit into from
Feb 15, 2012
Merged

Bugfix in listener refreshPosition() #19

merged 1 commit into from
Feb 15, 2012

Conversation

jkm9000
Copy link
Contributor

@jkm9000 jkm9000 commented Feb 15, 2012

Replacing hardcoded 'position' field with $this->_options['name'] so that refreshPosition works with names other than the default of position.

@jkm9000
Replacing hardcoded 'position' field with $this->_options['name'] so
2bc87f4 
that refreshPosition works with other names.
bshaffer added a commit that referenced this pull request Feb 15, 2012
@bshaffer
Merge pull request #19 from jkm9000/remove_hardcoded_position
b077121 
Bugfix in listener refreshPosition()
@bshaffer bshaffer merged commit b077121 into bshaffer:master Feb 15, 2012
@bshaffer
Copy link
Owner

Good catch. Thank you!

@bshaffer
Copy link
Owner

All tests are go: http://travis-ci.org/#!/bshaffer/csDoctrineActAsSortablePlugin/builds/682066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkm9000 @bshaffer