Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable customizers for GRPC transport via configurer beans #230

Merged
merged 7 commits into from
Dec 9, 2019
Merged

Pluggable customizers for GRPC transport via configurer beans #230

merged 7 commits into from
Dec 9, 2019

Conversation

lanwen
Copy link
Collaborator

@lanwen lanwen commented Dec 2, 2019

This PR just opens the way on more lightweight plugins to add something for the GRPC transport. E.g. auth.

The approach is quite simple, so if it's fine, I'll add some tests.

bsideup
bsideup requested changes Dec 3, 2019
View reviewed changes
Copy link
Owner

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests? :)

@bsideup bsideup added the enhancement New feature or request label Dec 3, 2019
@bsideup bsideup added this to the next milestone Dec 3, 2019
@lanwen lanwen requested a review from bsideup December 4, 2019 23:21
@lanwen
Copy link
Collaborator Author

lanwen commented Dec 4, 2019

Should I play with different classloaders somehow? Will the one plugin find beans of another plugin that easily? Seems this part is not exactly clear for me for now.

@bsideup
Copy link
Owner

bsideup commented Dec 6, 2019

@lanwen plugins use applicationContext.registerBean to register their components, which means that at the moment of a context refresh they will all be registered in the same ApplicationContext.

@lanwen lanwen requested a review from bsideup December 8, 2019 22:48
bsideup
bsideup approved these changes Dec 9, 2019
View reviewed changes
Copy link
Owner

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsideup bsideup merged commit 168aafa into master Dec 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the configurer branch December 9, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lanwen @bsideup