Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC jwt based call authentication #258

Merged
merged 11 commits into from
Feb 13, 2020
Merged

GRPC jwt based call authentication #258

merged 11 commits into from
Feb 13, 2020

Conversation

lanwen
Copy link
Collaborator

@lanwen lanwen commented Feb 5, 2020

Partially addresses #188

Channel auth would follow as a separate PR

@lanwen lanwen changed the title GRPC jwt based authentication GRPC jwt based call authentication Feb 5, 2020
@Test
void shouldAddWithHmac512() {
applicationContextRunner = applicationContextRunner.withPropertyValues(
"spring.profiles.active: not_gateway",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not_gateway but has a bean? Huh?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I require gateway profile? I would expect that it wouldn't be a situation when grpc.auth has some setup, but grpc itself is disabled. That's why I simplified this config and left it independently from the anything else.

@lanwen
Copy link
Collaborator Author

lanwen commented Feb 6, 2020

blocked now by #259

@@ -1 +1,2 @@
org.gradle.caching=true
version=0.0.1-SNAPSHOT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to define it, otherwise pf4j complained for a unparseable version during plugins startup (seems plugin dependency triggered that parsing, even there is no version specified there)

gradle.properties Outdated Show resolved Hide resolved
@lanwen lanwen requested a review from bsideup February 7, 2020 23:33
@bsideup bsideup added this to the next milestone Feb 13, 2020
@bsideup bsideup merged commit dd1d42e into master Feb 13, 2020
@bsideup bsideup deleted the grpc-auth branch February 13, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants