Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't call super #3

Merged
merged 1 commit into from
May 21, 2013
Merged

don't call super #3

merged 1 commit into from
May 21, 2013

Conversation

mackuba
Copy link
Contributor

@mackuba mackuba commented May 20, 2013

If you only enable growl-rspec formatter, you get output like this:

No DRb server is running. Running in local process instead ...

Run options: exclude {:capybara=>true}

Finished in 0.02603 seconds
4 examples, 0 failures
>

So there are no standard "...." progress dots. If I want to see them too, then I can enable two formatters, which is a feature RSpec supports. But then I get output like this:

No DRb server is running. Running in local process instead ...

Run options: exclude {:capybara=>true}
Run options: exclude {:capybara=>true}
....

Finished in 0.11286 seconds
4 examples, 0 failures

Finished in 0.11286 seconds
4 examples, 0 failures
>

Because growl-rspec is calling the superclass implementations of the base text formatter which prints those summaries second time. If I remove the two super calls, then I get what I expect (growl-rspec only shows the notification and the other formatter prints the dots and summaries).

if you call the superclass methods, summaries will be printed twice
if you configure rspec to use two formatters (which you might want
to do since growl-rspec won't show you the progress dots)
bsingr added a commit that referenced this pull request May 21, 2013
@bsingr bsingr merged commit b187d36 into bsingr:master May 21, 2013
@bsingr
Copy link
Owner

bsingr commented May 21, 2013

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants