Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the requested changes #85

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Conversation

shramanpaul
Copy link

@shramanpaul shramanpaul commented Jul 14, 2023

Overview

  1. This PR fixes or fixes part of [BUG]: Fix the product page #78 .
  2. This PR does the following: [Fixed the UI of product page to make them look alike the figma design.
    changed the font and color of the radio button. Fixed the spacing between the buttons.
    Made the color selector functional.

Essential Checklist

  • The PR title starts with "Fix [BUG]: Fix the product page #78 "
  • "Allow edits from maintainers" is checked.
  • The PR is made from a branch that's called "changes".

Proof that changes are correct

WhatsApp Image 2023-07-14 at 23 30 29

PR Pointers

@tushitshukla03 PTAL

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for merch-site ready!

Name Link
🔨 Latest commit a6c942e
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/64b5147536b2c800086aa54d
😎 Deploy Preview https://deploy-preview-85--merch-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tushitshukla03
Copy link
Collaborator

@shramanpaul color selection still not working

@shramanpaul
Copy link
Author

getit006.mp4

@tushitshukla03 it is working on my local machine PTAL

@shramanpaul
Copy link
Author

made the changes as requested @tushitshukla03 PTAL

Copy link
Collaborator

@thejaysharma thejaysharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @shramanpaul Good Job. :)

@tushitshukla03
Copy link
Collaborator

@shramanpaul color selection is once again misplaced is mobile view. It was at correct position in main.

@shramanpaul
Copy link
Author

@tushitshukla03 I have made the changes PTAL.

@tushitshukla03 tushitshukla03 merged commit 216b7f8 into bsoc-bitbyte:main Jul 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix the product page
3 participants