fix options.dir can not work issue #7
Conversation
| function generateBundle(options, rendered) { | ||
| const dir = options.dir || dirname(options.dest || options.file); | ||
| function generateBundle(bunldeOptions, rendered) { | ||
| const dir = options.dir || dirname(bunldeOptions.dest || bunldeOptions.file); |
There was a problem hiding this comment.
This appears to be equivalent?
There was a problem hiding this comment.
use bunldeOptions to prevent options params of createFilter not be override by generateBundle, so that options.dir can be correct.
There was a problem hiding this comment.
Ah I see, this is potentially a variable shadowing issue. I misread before. 🤔
You actually want the local options: OutputOptions param here. The outer options variable is the plugin options.
The naming/shadowing is definitely confusing here. I will change those.
I don't think there's a bug here, though. Could you add a failing test case to demonstrate the issue?
There was a problem hiding this comment.
if we don't rename the inner option to another name, options.dir can not be assign to const dir correctly, which make user cannot set output's path.
There was a problem hiding this comment.
This plugin does not provide a plugin level option dir. That is configured via your rollup config, which comes from the options param passed to generateBundle by rollup.
This plugin currently only writes files to the rollup output directory, no option for a configurable subdirectory is provided. Is that what you are looking for?
control output path by
options.dir