Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for matching repos with dots in their name #84

Conversation

jasonrudolph
Copy link
Collaborator

Before

before

After

after


I hope this helps. If there's anything you'd like to see changed in order to get this suitable to be merged, just let me know. 馃檱

@bswinnerton
Copy link
Owner

bswinnerton commented Oct 29, 2017

Thank you for the pull request, @jasonrudolph!

There were two odd things that I noticed with this pull request, neither of which were a result of your changes.

  1. I noticed that tests weren't being run in Circle CI on pull requests which originate from a fork, which I resolved by following these instructions.
  2. When checking out this pull request locally to test, I noticed that when running script/build I was getting a different output than what you had generated and submitted. At first, I thought this was perhaps because you had forgotten to run script/build, which prompted me to open Add test to ensure bundle.min.js was updated聽#85. But I ultimately realized that you were using a newer version of Babel than I was. So I updated the bundle.min.js file to use the latest version of Babel, as well as added a test to resolve Add test to ensure bundle.min.js was updated聽#85 in Add test to ensure script/build was run聽#86.

I'm writing both of these things mostly for the sake of posterity, but wanted to leave it here in case you were curious why I had merged master into your branch before merging.

Thank you for the submission! I especially appreciated the before and after gifs to showcase the changes. I'll cut a new release later today.

@bswinnerton bswinnerton merged commit de23811 into bswinnerton:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants