Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main.h:441:42: error: 'CTxDestination' does not name a type #4

Closed
unsystemizer opened this issue Feb 20, 2016 · 5 comments
Closed

main.h:441:42: error: 'CTxDestination' does not name a type #4

unsystemizer opened this issue Feb 20, 2016 · 5 comments
Labels
bug

Comments

@unsystemizer
Copy link

Getting this on Raspbian with bitcoin-addrindex-0.12.0 branch:

make[3]: Leaving directory '/blockchain/source/bitcoin-addrindex-0.12/src/secp256k1'
  CXX      libbitcoin_server_a-httpserver.o
  CXX      libbitcoin_server_a-init.o
In file included from checkpoints.cpp:9:0:
main.h:441:42: error: 'CTxDestination' does not name a type
 bool FindTransactionsByDestination(const CTxDestination &dest, std::set<CExtDiskTxPos> &setpos);
                                          ^
Makefile:3729: recipe for target 'libbitcoin_server_a-checkpoints.o' failed
make[2]: *** [libbitcoin_server_a-checkpoints.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from init.cpp:22:0:
main.h:441:42: error: 'CTxDestination' does not name a type
 bool FindTransactionsByDestination(const CTxDestination &dest, std::set<CExtDiskTxPos> &setpos);
                                          ^
Makefile:3771: recipe for target 'libbitcoin_server_a-init.o' failed
make[2]: *** [libbitcoin_server_a-init.o] Error 1
make[2]: Leaving directory '/blockchain/source/bitcoin-addrindex-0.12/src'
Makefile:6904: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/blockchain/source/bitcoin-addrindex-0.12/src'
Makefile:641: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

BItcoin Issue 2802 (2802#issuecomment-21841017) is the only similar error I was able to find on this.
@btcdrak btcdrak added the bug label Feb 20, 2016
@JornC
Copy link

JornC commented Feb 23, 2016

Managed to fix some of the errors:

JornC@af04fbd

Still having issues in txdb.cpp with the CDB changes that are beyond our ability of solving.

Not submitting a pull because the above fix is incomplete.

Cheers. 👍

@GIJensen GIJensen mentioned this issue Feb 24, 2016
Merged
@btcdrak
Copy link
Owner

btcdrak commented Feb 24, 2016

Should be fixed in a89810b

@btcdrak
Copy link
Owner

btcdrak commented Feb 24, 2016

@JornC @unsystemizer Please confirm.

@JornC
Copy link

JornC commented Feb 24, 2016

http://srv1.yogh.io/#json:getinfo
http://srv1.yogh.io/testnet/#json:getinfo

http://srv1.yogh.io/#addr:id:39XFme16GP2FMi2TCStZ2ciNNqe19jwDJb

Confirmed. Works fully. Thanks.

@unsystemizer
Copy link
Author

Pi is slow so it's going to take hours to build, but I'm past that point where I saw this error, so it's unlikely that this hasn't been fixed. I think you can close this.
Edit: built successfully.

@btcdrak btcdrak closed this as completed Feb 24, 2016
btcdrak pushed a commit that referenced this issue Dec 19, 2016
@sipa
Squashed 'src/crypto/ctaes/' changes from cd3c3ac..003a4ac
8501bed 
003a4ac Merge #5: fix typo
5254f14 [trivial] Fix typo
e7c0aab Merge #4: Fix some comments
d07cead Fix some comments

git-subtree-dir: src/crypto/ctaes
git-subtree-split: 003a4acfc273932ab8c2e276cde3b4f3541012dd
btcdrak pushed a commit that referenced this issue Aug 14, 2018
Merge bitcoin#13806: qa: Fix bench/block_assemble assert failure
4d550ff 
6f53edb Acquire cs_main before ATMP call in block_assemble bench (James O'Beirne)

Pull request description:

  Calling `bench_bitcoin` currently fails due to calling ATMP without acquiring cs_main first in the recently added block_assemble bench (bitcoin#13219).

  ```
  $ cat <(uname -a) <(gcc --version)

  Linux james 4.4.0-119-generic bitcoin#143+jamesob SMP Mon Apr 16 21:47:24 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux
  gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609

  $ ./src/bench/bench_bitcoin

  WARNING: This is a debug build - may result in slower benchmarks.
  # Benchmark, evals, iterations, total, min, max, median
  Assertion failed: lock cs_main not held in validation.cpp:566; locks held:
  [1]    19323 abort (core dumped)  ./src/bench/bench_bitcoin
  ```

  ```
  (gdb) bt
  #0  0x00007fbdc9cf5428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
  #1  0x00007fbdc9cf702a in __GI_abort () at abort.c:89
  #2  0x0000555a19580dc5 in AssertLockHeldInternal (pszName=pszName@entry=0x555a19834549 "cs_main",
      pszFile=pszFile@entry=0x555a1988a001 "validation.cpp", nLine=nLine@entry=566, cs=cs@entry=0x555a19ba55c0 <cs_main>) at sync.cpp:157
  #3  0x0000555a194b395f in AcceptToMemoryPoolWorker (chainparams=..., pool=..., state=...,
      ptx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=1532964079,
      plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=@0x7ffcbc1719d8: 0, coins_to_uncache=std::vector of length 0, capacity 0,
      test_accept=false) at validation.cpp:566
  #4  0x0000555a194ba661 in AcceptToMemoryPoolWithTime (chainparams=..., pool=..., state=...,
      tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=<optimized out>,
      plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=0, test_accept=false) at validation.cpp:998
  #5  0x0000555a194ba7ce in AcceptToMemoryPool (pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0,
      pfMissingInputs=pfMissingInputs@entry=0x0, plTxnReplaced=plTxnReplaced@entry=0x0, bypass_limits=bypass_limits@entry=false, nAbsurdFee=0,
      test_accept=false) at validation.cpp:1014
  #6  0x0000555a19363fbe in AssembleBlock (state=...) at bench/block_assemble.cpp:102
  #7  0x0000555a193654d3 in std::_Function_handler<void (benchmark::State&), void (*)(benchmark::State&)>::_M_invoke(std::_Any_data const&, benchmark::State&) (__functor=..., __args#0=...) at /usr/include/c++/5/functional:1871
  #8  0x0000555a193501d7 in std::function<void (benchmark::State&)>::operator()(benchmark::State&) const (this=this@entry=0x555a1ba2cda0,
      __args#0=...) at /usr/include/c++/5/functional:2267
  #9  0x0000555a1934ec4c in benchmark::BenchRunner::RunAll (printer=..., num_evals=5, scaling=<optimized out>, filter=..., is_list_only=false)
      at bench/bench.cpp:121
  #10 0x0000555a1934ade9 in main (argc=<optimized out>, argv=<optimized out>) at bench/bench_bitcoin.cpp:92
  ```

Tree-SHA512: fdd7b28ff123ccea7a4f334d53f735d0c0f94aa9cc52520c2dd34dca45d78c691af64efcd32366fc472fedffbd79591d2be2bb3bfc4a5186e8712b6b452d64e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JornC @btcdrak @unsystemizer