handled empty BinStr entropy

btclib-org · May 21, 2020 · 528d415 · 528d415
1 parent 1d7db03
commit 528d415
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/btclib/entropy.py b/btclib/entropy.py
@@ -292,7 +292,7 @@ def randbinstr(
     - possibly hashed (if requested)
     """
 
-    if entropy is None:
+    if entropy is None or entropy == "":
         i = secrets.randbits(bits)
     else:
         if len(entropy) > bits:

diff --git a/btclib/tests/test_entropy.py b/btclib/tests/test_entropy.py
@@ -239,9 +239,15 @@ def test_randbinstr():
         bits = 256
         binstr = randbinstr(bits, hash=hash)
         assert len(binstr) == bits
+        binstr2 = randbinstr(bits, "", hash=hash)
+        assert len(binstr2) == bits
+        assert binstr != binstr2
         binstr2 = randbinstr(bits, hash=hash)
         assert len(binstr2) == bits
         assert binstr != binstr2
+        binstr2 = randbinstr(bits, "", hash=hash)
+        assert len(binstr2) == bits
+        assert binstr != binstr2
 
         bits = 512
         binstr = randbinstr(bits, hash=hash)