Skip to content

Commit

Permalink
fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
fametrano committed Jan 1, 2023
1 parent a3ef762 commit dfaa486
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 38 deletions.
3 changes: 3 additions & 0 deletions .markdownlint.json
@@ -0,0 +1,3 @@
{
"MD007": { "indent": 4 }
}
26 changes: 13 additions & 13 deletions CONTRIBUTING.md
Expand Up @@ -104,24 +104,24 @@ Commit the changes to your fork once you are happy with them.
When you're finished with the changes, create a pull request (PR).

- Don't forget to
[link PR to issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
if you are solving one.
[link PR to issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
if you are solving one.
- Enable the checkbox to
[allow maintainer edits](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
so the branch can be updated for a merge.
Once you submit your PR, team members will review your proposal.
We may ask questions or request additional information.
[allow maintainer edits](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
so the branch can be updated for a merge.
Once you submit your PR, team members will review your proposal.
We may ask questions or request additional information.
- We may ask for changes to be made before a PR can be merged, either using
[suggested changes](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request)
or pull request comments.
You can apply suggested changes directly through the UI.
You can make any other changes in your fork, then commit them to your branch.
[suggested changes](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request)
or pull request comments.
You can apply suggested changes directly through the UI.
You can make any other changes in your fork, then commit them to your branch.
- [Sourcery](https://sourcery.ai/) might suggest changes, please accept them.
- As you update your PR and apply changes, mark each conversation as
[resolved](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations).
[resolved](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations).
- If you run into any merge issues, checkout this
[git tutorial](https://github.com/skills/resolve-merge-conflicts)
to help you resolve merge conflicts and other issues.
[git tutorial](https://github.com/skills/resolve-merge-conflicts)
to help you resolve merge conflicts and other issues.

### Your PR is merged

Expand Down
2 changes: 1 addition & 1 deletion HISTORY.md
Expand Up @@ -30,7 +30,7 @@ Major changes includes:
- the hashes.fingerprint function, removed in the previous version,
has been reinstated in the to_pub_key module
- encode_num and decode_num have been moved from
script.op_codes to utils
script.op_codes to utils
- op_pushdata and op_str have been renamed to
serialize_bytes_command and serialize_str_command
- script.op_codes has been removed and its functions merged in script
Expand Down
24 changes: 10 additions & 14 deletions README.md
Expand Up @@ -41,27 +41,23 @@ Included features are:
- modulo algebra functions (gcd, inverse, legendre symbol, square root)
- octets / integer / point / var_int / var_bytes helper functions
- elliptic curve class

- fast algebra implemented using Jacobian coordinates
- double scalar multiplication (Straus's algorithm, also known as
Shamir's trick)
- multi scalar multiplication (Bos-coster's algorithm)
- point simmetry solution: odd/even, low/high, and quadratic residue

- elliptic curves: SEC 1 v1 and v2, NIST, Brainpool, and
low cardinality test curves
- fast algebra implemented using Jacobian coordinates
- double scalar multiplication (Straus's algorithm, also known as
Shamir's trick)
- multi scalar multiplication (Bos-coster's algorithm)
- point simmetry solution: odd/even, low/high, and quadratic residue
- elliptic curves: SEC 1 v1 and v2, NIST, Brainpool, and
low cardinality test curves
- ECDSA signature with (transaction) DER encoding
- ECDSA signature with (message) compact encoding: standard p2pkh and
[BIP137](https://github.com/bitcoin/bips/blob/master/bip-0137.mediawiki)/[Electrum](https://electrum.org/#home)
extensions to p2wpkh and p2wpkh-p2sh
- EC Schnorr signature (according to
[BIP340](https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki)
bitcoin standardization)

- batch validation
- threshold signature (see test-suite)
- MuSig multi-signature (see test-suite)

- batch validation
- threshold signature (see test-suite)
- MuSig multi-signature (see test-suite)
- Borromean ring signature
- [RFC 6979](https://tools.ietf.org/html/rfc6979:) to make signature
schemes deterministic
Expand Down
18 changes: 8 additions & 10 deletions TODO.md
Expand Up @@ -14,14 +14,14 @@
- add sign(address, msg) using wallet infrastrucure
- isinstance(entr, bytearray) or isinstance(entr, bytes)
- optimizations:
- <https://en.wikipedia.org/wiki/Elliptic_curve_point_multiplication>
- <https://cryptojedi.org/peter/data/eccss-20130911b.pdf>
- <https://arxiv.org/abs/1801.08589>
- <https://ecc2017.cs.ru.nl/slides/ecc2017school-castryck.pdf>
- <https://hal.archives-ouvertes.fr/hal-00932199/document>
- <https://iacr.org/workshops/ches/ches2006/presentations/Douglas%20Stebila.pdf>
- <https://eprint.iacr.org/2005/419.pdf>
- <https://www.esat.kuleuven.be/cosic/publications/article-2293.pdf>
- <https://en.wikipedia.org/wiki/Elliptic_curve_point_multiplication>
- <https://cryptojedi.org/peter/data/eccss-20130911b.pdf>
- <https://arxiv.org/abs/1801.08589>
- <https://ecc2017.cs.ru.nl/slides/ecc2017school-castryck.pdf>
- <https://hal.archives-ouvertes.fr/hal-00932199/document>
- <https://iacr.org/workshops/ches/ches2006/presentations/Douglas%20Stebila.pdf>
- <https://eprint.iacr.org/2005/419.pdf>
- <https://www.esat.kuleuven.be/cosic/publications/article-2293.pdf>
- better mimic of electrum entropy search, they probably have the words inverted
- BIP44 in address_from...
- primitives for interactive threshold and musig
Expand All @@ -39,5 +39,3 @@
- SSA: ask about why e=e(k), making impossible to select e, k indipendently
- SSA: ask about benefit of removing 02/03 from pub_key
- SSA: suggest better k

- compare of dsa.rfc6979_ and ssa.det_nonce_

0 comments on commit dfaa486

Please sign in to comment.