Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lightning Terminal fragment #512

Merged
merged 7 commits into from
Dec 1, 2021

Conversation

dennisreimann
Copy link
Member

@dennisreimann dennisreimann commented Aug 25, 2021

Closes btcpayserver/btcpayserver#2706.

How to test

Go to your BTCPay Server directory and run the following commands:

# Checkout this pull request
git remote add dennisreimann https://github.com/dennisreimann/btcpayserver-docker.git
git fetch dennisreimann
git checkout -b dennisreimann/lit
git pull dennisreimann lit

# Prepare
export BTCPAYGEN_ADDITIONAL_FRAGMENTS="$BTCPAYGEN_ADDITIONAL_FRAGMENTS;opt-add-lightning-terminal"
export LIT_PASSWD="aSecretPasswordLikeRockstar"

# Install
. ./btcpay-setup.sh -i

# Check
docker logs generated_lnd_lit_1

The log should give you an output like this:

2021-11-03 07:42:05.976 [INF] LITD: Dialing lnd gRPC server at lnd_bitcoin:10009
2021-11-03 07:42:06.072 [INF] LITD: Listening for http_tls on: 127.0.0.1:8443
2021-11-03 07:42:06.073 [INF] LITD: Listening for http on: [::]:8080
----------------------------------------------------------
 Lightning Terminal (LiT) by Lightning Labs               
                                                          
 Operating mode      remote                                   
 Node status         online                                   
 Alias               My BTCPay Server                                 
 Version             0.13.3-beta commit=basedon-v0.13.3-beta-fresh-btcpay                                   
 Web interface       127.0.0.1:8443, 0.0.0.0:8080 (open https://127.0.0.1:8443 or http://localhost:8080 in your browser)         
----------------------------------------------------------
2021-11-03 07:42:06.381 [INF] LNDC: Creating lnd connection to lnd_bitcoin:10009
2021-11-03 07:42:06.382 [INF] LNDC: Connected to lnd
  1. Go to your BTCPay Server backend and see the Server Settings > Services:
  2. You should see "Lightning Terminal" under the "Other external services".
  3. Open LiT by clicking the "See information" link on the right side.
  4. Log in using the password chosen in the setup (see bash commands) and see if everything works as expected.

Production/nginx.tmpl Show resolved Hide resolved
Production/nginx.tmpl Outdated Show resolved Hide resolved
@dennisreimann dennisreimann marked this pull request as ready for review November 2, 2021 13:07
contrib/build-all-images.sh Outdated Show resolved Hide resolved
@dennisreimann
Copy link
Member Author

@astupidmoose can you help testing this?

@astupidmoose
Copy link
Contributor

I'll see what I can do. I don't think I have any test instances running but if I get some time I can try in the next few days.

@dennisreimann
Copy link
Member Author

I've added instructions on how to test this PR, let me know in case I can be of more help.

@astupidmoose
Copy link
Contributor

Setup and install worked. Gonna play around with Loop and Pool in a bit, but that would be an issue with Lightning Terminal if anything. This docker seems to be working good.

One thing I noticed was my logs were a bit different:

2021-11-18 18:32:54.381 [INF] LITD: Listening for http on: [::]:8080
----------------------------------------------------------
 Lightning Terminal (LiT) by Lightning Labs

 Operating mode      remote
 Node status         locked
 Alias               ???? (node is locked)
 Version             ???? (node is locked)
 Web interface       127.0.0.1:8443, 0.0.0.0:8080 (open https://127.0.0.1:8443 or http://localhost:8080 in your browser)
----------------------------------------------------------
2021-11-18 18:32:54.649 [INF] LNDC: Creating lnd connection to lnd_bitcoin:10009
2021-11-18 18:32:54.650 [INF] LNDC: Connected to lnd

Not sure why I have "locked", but this node is an XXS pruned node, so maybe the issue?

@dennisreimann
Copy link
Member Author

@guggero Du you know why it says node is locked in that case?

@guggero
Copy link
Contributor

guggero commented Nov 19, 2021

I don't know, is the wallet still locked maybe? Hard to say without seeing more of the log.

@NicolasDorier
Copy link
Member

you need to save LIT_PASSWD in BTCPAY_ENV_FILE. Check in helpers.sh.
Else it won't be saved, the next time you connect you connect to btcpay ssh and btcpay-up.sh, it will be removed.

@NicolasDorier
Copy link
Member

NicolasDorier commented Nov 21, 2021

Is there a way to avoid the LIT_PASSWD completely? What if it is empty, what happen?
Also need doc in the README.md, we list all fragments there.

@dennisreimann
Copy link
Member Author

dennisreimann commented Nov 21, 2021

Is there a way to avoid the LIT_PASSWD completely? What if it is empty, what happen?

It will refuse to start: could not load config: could not read UI password: mandatory password for UI not configured.

Also need doc in the README.md, we list all fragments there.

Rebased and added. 👍

@dennisreimann
Copy link
Member Author

@NicolasDorier Are there still any objections? I'd upgrade it to the just released v0.6.0-alpha and we can merge it then?

@NicolasDorier NicolasDorier merged commit 3d6d2a8 into btcpayserver:master Dec 1, 2021
tiero added a commit to nestpay/btcpayserver-docker that referenced this pull request Dec 20, 2021
* update dogecoin (btcpayserver#483)

* chore: bump thunderhub (btcpayserver#479)

* Update doc

* Bump GRS Core and c-lightning (btcpayserver#484)

* Bump GRS Core and c-lightning

* Update eclair

* Update BitCore version to 0.90.9.10 (btcpayserver#474)

Co-authored-by: dalijolijo <dalijolijo@v220200132547106119.bestsrv.de>

* Separate default liquid prune to own fragment (btcpayserver#457)

This allows users who dont want to prune their liquid node to exclude the pruning fragment. (allows rescanning for utxos)

* opt-*-memory supported by doge

* Upgrade Sphinx Relay to v2.1.3

* S3 backup provider (btcpayserver#438)

* Add S3 backup provider

Allows upload to S3

* Update backup.sh

* Update backup.sh

Co-authored-by: britttttk <39231115+britttttk@users.noreply.github.com>

* Update backup.sh

Co-authored-by: britttttk <39231115+britttttk@users.noreply.github.com>

* Update tor

* Revert "Update tor"

This reverts commit 365e990.

* Revert "Revert "Update tor""

This reverts commit a770141.

* bump transmuter

* Add Tallycoin Connect fragment

* Update to latest tallycoin_connect version

* Finalize Tallycoin Connect integration

* Add fragment to enable LND watchtower client

* Add opt-lnd-wtclient fragment description in README

* Add ability to customize watchtower sweep fee

* remove quotes from wtclient fragment

* Save LND_WTCLIENT_SWEEP_FEE to environment file

* Bump BTCPay/NBX (btcpayserver#505)

* Bump LND to v0.13.1-beta-withloop (btcpayserver#506)

* bump Clightning to 0.10.1 (btcpayserver#507)

* Update doc

* Revert "Bump LND to v0.13.1-beta-withloop (btcpayserver#506)"

This reverts commit 7574612.

* Hotfix for problems with LND 0.13.1 (btcpayserver#508)

* Revert "Revert "Bump LND to v0.13.1-beta-withloop (btcpayserver#506)""

This reverts commit b9777f9.

* Fetching version that waits for proper wallet unlock state before proceeding

* bump

* Bump RTL and Clightning-rest

Only for clightning, separate PR for lnd

* Update docker builder

* chore: update to dash 0.17.0.3 (btcpayserver#509)

* chore: update to dash 0.17.0.3

* chore: update dash.conf defaults

* Bump RTL

* Update Tallycoin Connect to v1.4.0

* Update Sphinx Relay to v2.2.0

* bump btcpay

* Update NBX

* Update liquid.yml

* bump nbx

* bump nbx

* Update bitcoin-clightning.yml

* bump nnbx

* bump nbx

* bump nbx

* Bump btcpay

* Revert "Bump btcpay"

This reverts commit 64fe7db.

* Revert "Revert "Bump btcpay""

This reverts commit 40f2765.

* Bump RTL

* bump nbx

* bump

* New utxo-set for FastSync

* Bump Monero to v0.17.2.3 (btcpayserver#522)

Co-authored-by: Seth Simmons <sethsimmons@users.noreply.github.com>
Co-authored-by: Seth Simmons <sethsimmons@pm.me>
Co-authored-by: Seth Simmons <ssimmons2@theark.cloud>

* Bump NBX (btcpayserver#528)

* Update FastSync sig for 699714 and testnet (btcpayserver#532)

* Update signature for fastsync (btcpayserver#526)

* Provide plugin directory for Clightning (btcpayserver#518)

* Make btcpay-restart properly restart everything (Fix btcpayserver#524)

* Update nbx

* Update bitcoin-clightning.yml

* Bumping RTL to 0.11.2 due to bug with peering (btcpayserver#523)

* Script fix (btcpayserver#520)

* Feat/fireflyiii (btcpayserver#344)

* Adding Firefly-iii opt fragment

* Adding environment variable to force creation of db

* Instructing postgres to create database

* Switching exposing default port, running create db command

* Remove grep command for postgres container

* Removing database creation on postgres container start

* Adding required App Key env variable

* Updating nginx rewriting

* Updating firefly nginx confugration traying to make it work with subdirectory

firefly-iii/firefly-iii#2848 (comment)

* Trying to rewrite

* Reconfiguring nginx to pass headers

* Updating docker fragment

* Last try

* Allowing firefly iii to be hosted on other domain

* Fixing docker compose env variables

* Exposing ports for external communication

* Ports exposing

* Updating firefly host reference

* Matching service name and VIRTUAL_HOST_NAME

* Getting nginx to redirect to port 8080

* update and adapt

* Adapt firefly to be with dedicated domain

* Adapt Docker file builder to support non github builds

* Make firefly init create db only if not exists + run full recommended upgrade procedure

Co-authored-by: rockstardev <rockstardev@users.noreply.github.com>

* Update dogecoin.yml (btcpayserver#533)

* Set Default ACME production

* Update Lightning-Rest

* bump btcpay

* Revert "Provide plugin directory for Clightning" (btcpayserver#535)

* Bump Bitcoin core

* Add joinmarket support

* Activate gzip

* Upgrade postgres

* Fix firefly link

* Fix instructions link for docs

* Fix video link and preview image for docs

* Markdown formatting

* Revert "Upgrade postgres"

This reverts commit 9741499.

* Revert "Revert "Upgrade postgres""

This reverts commit d321c09.

* Warning

* Use supervisord for joinmarket

* Fix jm.sh doc

* Fix doc

* Fix doc

* Handle postgres migration for old install

* Do not parse settings.json

* Fix postgres update for arm32

* Fix postgres update for arm7

* Add documentation if postgres update fail on rapsberry pi 4

* Update woocommerce

* Bump Tor Relay to latest stable release (4.5.9)

* Add joinmarket for arm64 and arm32

* Improve NDLC disclaimer (btcpayserver#538)

* Add chatwoot support system (btcpayserver#353)

Co-authored-by: Andrew Camilleri <kukks@btcpayserver.org>

* Bump transmuter

* Revert "Bump transmuter"

This reverts commit 8280398.

* bump bitcoin core 22.0, fix issue about corrupt settings.json

* Revert "bump bitcoin core 22.0, fix issue about corrupt settings.json"

This reverts commit a092054.

* Revert "Revert "bump bitcoin core 22.0, fix issue about corrupt settings.json""

This reverts commit dcf0e55.

* Remove bitcoin taproot cc

* Bump NBX

* Bump joinmarket to fix receive-payjoin

* Bump joinmarket to fix receive-payjoin

* Upgrade Tallycoin Connect (btcpayserver#541)

Now it also supports arm32v7 and arm64v8 architectures.

* update doc

* Bump LND to v0.13.3-beta (btcpayserver#540)

* Switch to our own postgres container

* Update jm

* update postgres

* bump postgres

* bump postgres

* bump nbxplorer

* bump

* Make sure only one lightning implementation is selected

* bump btcpay

* Bump ThunderHub version (btcpayserver#547)

* Upgrade Tallycoin Connect (btcpayserver#541)

* Upgrade Tallycoin Connect

Now it also supports arm32v7 and arm64v8 architectures.

* Correct Dockerfile repo

* Add images to Docker file builder helper

* Fix GitHub link

* Automatically update libseccomp2 on rapsberry pi 4

* Bump BTCPay

* bump BTCPay

* Update opt-add-btctransmuter.yml

* Update libseccomp2 on any arm32 buster hosts

* bump btcpay

* update NBXplorer

* bump btcpay

* bump LND and BTCPay

* bump lnd

* bump clightning

* bump woocommerce

* Add Lightning Terminal fragment (btcpayserver#512)

* Add Lightning Terminal fragment

* Remove mappings and variables

* Version update

* Update contrib/build-all-images.sh

Co-authored-by: Oliver Gugger <gugger@gmail.com>

* Update docker version

* Add Lightning Terminal to fragments list

* Upgrade LiT to v0.6.0

Co-authored-by: Oliver Gugger <gugger@gmail.com>

* Update Litecoin

* fix litecoin

* Update EPS

* Bump monacoin to 0.20.2 (btcpayserver#563)

* Update Lightning Terminal (btcpayserver#562)

Co-authored-by: Andrew Camilleri <kukks@btcpayserver.org>

* bump btcpay

* bump liquid

Co-authored-by: Mike Olthoff <mike@olthoff.ca>
Co-authored-by: Anthony Potdevin <31413433+apotdevin@users.noreply.github.com>
Co-authored-by: nicolas.dorier <nicolas.dorier@gmail.com>
Co-authored-by: gruve-p <gruve-p@users.noreply.github.com>
Co-authored-by: Dali <37987466+dalijolijo@users.noreply.github.com>
Co-authored-by: dalijolijo <dalijolijo@v220200132547106119.bestsrv.de>
Co-authored-by: Andrew Camilleri <kukks@btcpayserver.org>
Co-authored-by: Dennis Reimann <mail@dennisreimann.de>
Co-authored-by: Patrick <privat@skyraptor.eu>
Co-authored-by: britttttk <39231115+britttttk@users.noreply.github.com>
Co-authored-by: Richard Safier <richardj@safier.com>
Co-authored-by: rockstardev <5191402+rockstardev@users.noreply.github.com>
Co-authored-by: Kukks <evilkukka@gmail.com>
Co-authored-by: strophy <32928115+strophy@users.noreply.github.com>
Co-authored-by: Seth Simmons <sethsimmons@protonmail.com>
Co-authored-by: Seth Simmons <sethsimmons@users.noreply.github.com>
Co-authored-by: Seth Simmons <sethsimmons@pm.me>
Co-authored-by: Seth Simmons <ssimmons2@theark.cloud>
Co-authored-by: Jonathan Underwood <junderwood@bitcoinbank.co.jp>
Co-authored-by: Downet <78277193+downet@users.noreply.github.com>
Co-authored-by: rockstardev <rockstardev@users.noreply.github.com>
Co-authored-by: Mike Olthoff <mike@stufftech.io>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: xpayserver <67416048+xpayserver@users.noreply.github.com>
Co-authored-by: Oliver Gugger <gugger@gmail.com>
Co-authored-by: Jin Eguchi <wakiyamap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants