Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payjoin client incompatibility with BIP78 #1984

Closed
kristapsk opened this issue Oct 14, 2020 · 1 comment · Fixed by #1985
Closed

Payjoin client incompatibility with BIP78 #1984

kristapsk opened this issue Oct 14, 2020 · 1 comment · Fixed by #1985

Comments

@kristapsk
Copy link
Contributor

Current implementation of Payjoin client in BTCPay isn't compatible with BIP78, as it encodes request in hex, not base64. Tested with JoinMarket payjoin receiver and it fails.

Likely this line needs to be changed, but I don't have test environment for that right now (I used testnet.demo.btcpayserver.org) -

new StringContent(originalTx.ToHex(), Encoding.UTF8, "text/plain"), cancellationToken);
.

See zkSNACKs/WalletWasabi#4427.

Kukks added a commit to Kukks/btcpayserver that referenced this issue Oct 14, 2020
@Kukks
Copy link
Member

Kukks commented Oct 14, 2020

Thanks, fixed it for the next release

Kukks added a commit that referenced this issue Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants