Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS Print: Properly handle free items #5999

Closed
dennisreimann opened this issue May 23, 2024 · 0 comments · Fixed by #6009
Closed

POS Print: Properly handle free items #5999

dennisreimann opened this issue May 23, 2024 · 0 comments · Fixed by #6009
Assignees
Milestone

Comments

@dennisreimann
Copy link
Member

Follow-up to #5997: Right now free items (cost of 0) return a bad request, because the LNURL cannot get generated. First of all we need to find out how to handle this and if possible generate a LNURL that behaves properly.

@dennisreimann dennisreimann self-assigned this May 23, 2024
@pavlenex pavlenex added this to the 1.13.x milestone May 23, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue May 26, 2024
We cannot generate a proper LNURL response for free items, hence we should not show them in the print view.

Closes btcpayserver#5999.
NicolasDorier pushed a commit that referenced this issue Jun 5, 2024
We cannot generate a proper LNURL response for free items, hence we should not show them in the print view.

Closes #5999.
NicolasDorier pushed a commit that referenced this issue Jun 5, 2024
We cannot generate a proper LNURL response for free items, hence we should not show them in the print view.

Closes #5999.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants