Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS: Allow overpay for articles with minimum price #5997

Merged
merged 1 commit into from
May 23, 2024

Conversation

dennisreimann
Copy link
Member

Adjust the LNURL settings so that minimum price items aren't capped and can be overpaid.

Also fixes the missing LNURL response for free items to return a proper LNURL error instead of just 404.

Fixes #5995.

Adjust the LNURL settings so that minimum price items aren't capped and can be overpaid.

Also fixes the missing LNURL response for free items to return a proper LNURL error instead of just 404.

Fixes btcpayserver#5995.
@dennisreimann dennisreimann requested a review from Kukks May 22, 2024 11:00
@dennisreimann dennisreimann added this to the 1.13.x milestone May 22, 2024
Copy link
Member

@Kukks Kukks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, make sure you port this to 1.13.x branch too

@NicolasDorier NicolasDorier merged commit 89fcf86 into btcpayserver:master May 23, 2024
4 checks passed
NicolasDorier pushed a commit that referenced this pull request May 23, 2024
Adjust the LNURL settings so that minimum price items aren't capped and can be overpaid.

Also fixes the missing LNURL response for free items to return a proper LNURL error instead of just 404.

Fixes #5995.
@dennisreimann dennisreimann deleted the fix-5995 branch May 23, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: PosApp/PrintView - articles with minimum price are treated as fixed price on checkout
3 participants