Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pay button PNG image with an SVG #1034

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Replace pay button PNG image with an SVG #1034

merged 1 commit into from
Sep 20, 2019

Conversation

bolatovumar
Copy link
Contributor

fix #1030

Kukks
Kukks requested changes Sep 13, 2019
View reviewed changes
Copy link
Member

@Kukks Kukks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not delete the image file. If you do that and people upgrade, all their pay buttons would break

@NicolasDorier
Copy link
Member

Awesome. yeah just need to keep the png.

@bolatovumar
Copy link
Contributor Author

@Kukks would it make sense to export the SVG as a PNG in 2x resolution to fix the blurriness for those using the PNG as well? So this way I don't delete the PNG but replace it with one in 2x resolution so that it doesn't look blurry on high-res screens.

@Kukks
Copy link
Member

Kukks commented Sep 14, 2019

Sounds good to me

@bolatovumar
Copy link
Contributor Author

@Kukks alright, done

@NicolasDorier NicolasDorier merged commit 438fc34 into btcpayserver:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kukks Kukks Kukks requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pay button image looks blurry on iPhone
3 participants
@bolatovumar @NicolasDorier @Kukks