Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Consistency Updates (1.4.0) #3316

Merged
merged 16 commits into from
Jan 18, 2022

Conversation

dstrukt
Copy link
Member

@dstrukt dstrukt commented Jan 16, 2022

Might make sense to merge this after @dennisreimann's latest changes.

These are just aesthetic changes, header sizes, paddings, etc... to make things consistent, been a lot easier to spot with the latest updates.

A few minor tweaks I'd like to improve with this PR, but I need some help with:

  • Fix active state when "Account" is selected + sub-navigation @dennisreimann
  • "Profile" -> "Account" on Account tabbed navigation
  • Change "General Settings" to "General" in Store Settings & make it the first tab
  • "Email Server" -> "Email" in Server Settings in tabbed menu, change the content title from "Email" -> "Email Server"

The first item will close out one of the issues (#3180).

Added "Language" section:
Screen Shot 2022-01-15 at 4 28 34 PM

Moves API Key CTA to top right:
Screen Shot 2022-01-15 at 5 45 45 PM

@dennisreimann dennisreimann self-requested a review January 16, 2022 11:56
@pavlenex
Copy link
Contributor

To answer questions, I agree with all except these two:

Move "Language" section in "Checkout Appearance" to "General" in Store Settings

No, because this isn't a store language it's the language of the checkout page, so it's appropriate where it is.

"Checkout Appearance" -> "Checkout" in Store Settings tabbed menu

I don't think we should change it, it communicates what it really is, the appearance of your checkout page. If we do checkout it may confuse people thinking it's payment method setting or something else.

@dstrukt
Copy link
Member Author

dstrukt commented Jan 16, 2022

Ahh good call on the Language, thought this was App wide, noted.

That's a good point, I think I just took issue with it because there were multiple types of modifications (language, invoice, appearance), but maybe it's just because that word doesn't feels like it captures everything.. but I have no alternative suggestions, so will drop the issue for now.

@NicolasDorier
Copy link
Member

This probably break something in the CanSetupMail test ping @dennisreimann

@dstrukt
Copy link
Member Author

dstrukt commented Jan 17, 2022

Oh, wow the account text switch was more simple than I anticipated, thought more would be involved.

@dennisreimann dennisreimann added Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers labels Jan 17, 2022
Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All TODOs done now :)

The failing link check is unrelated - this one should be merged next, I'll then finish #3323 based on this.

@NicolasDorier NicolasDorier merged commit c3f73c0 into btcpayserver:master Jan 18, 2022
JarLob pushed a commit to JarLob/btcpayserver that referenced this pull request Jan 19, 2022
* updates

* updates

* updates

* updates

* updates

* moves api key CTA to top right

* updates

* more updates

* more updates

* Fix active state when "Account" is selected

* Update wording in subnav: Profile becomes Account

* Fix email test

* Update Emails wording

* Try to fix email test

* Make General first tab in store settings

Co-authored-by: Dennis Reimann <mail@dennisreimann.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants