-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Consistency Updates (1.4.0) #3316
Content Consistency Updates (1.4.0) #3316
Conversation
To answer questions, I agree with all except these two:
No, because this isn't a store language it's the language of the checkout page, so it's appropriate where it is.
I don't think we should change it, it communicates what it really is, the appearance of your checkout page. If we do |
Ahh good call on the Language, thought this was App wide, noted. That's a good point, I think I just took issue with it because there were multiple types of modifications (language, invoice, appearance), but maybe it's just because that word doesn't feels like it captures everything.. but I have no alternative suggestions, so will drop the issue for now. |
This probably break something in the CanSetupMail test ping @dennisreimann |
Oh, wow the account text switch was more simple than I anticipated, thought more would be involved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All TODOs done now :)
The failing link check is unrelated - this one should be merged next, I'll then finish #3323 based on this.
* updates * updates * updates * updates * updates * moves api key CTA to top right * updates * more updates * more updates * Fix active state when "Account" is selected * Update wording in subnav: Profile becomes Account * Fix email test * Update Emails wording * Try to fix email test * Make General first tab in store settings Co-authored-by: Dennis Reimann <mail@dennisreimann.de>
Might make sense to merge this after @dennisreimann's latest changes.
These are just aesthetic changes, header sizes, paddings, etc... to make things consistent, been a lot easier to spot with the latest updates.
A few minor tweaks I'd like to improve with this PR, but I need some help with:
The first item will close out one of the issues (#3180).
Added "Language" section:
Moves API Key CTA to top right: