Add support for Zcash #3387
Add support for Zcash #3387
Conversation
hhanh00
force-pushed
the
zcash-integration
branch
from
66e9d81
to
d59621c
Compare
|
Seems good. Remove the |
| @@ -97,8 +97,7 @@ | |||
| "BTCPAY_DOCKERDEPLOYMENT": "true", | |||
| "BTCPAY_RECOMMENDED-PLUGINS": "BTCPayServer.Plugins.Test", | |||
| "BTCPAY_CHEATMODE": "true" | |||
| }, | |||
| "applicationUrl": "https://localhost:14142/" | |||
There was a problem hiding this comment.
The Monero team didn't add anything and I didn't want to mess up the file. There are several altcoins after all.
| @@ -1259,6 +1259,20 @@ | |||
| "symbol":null, | |||
| "crypto":true | |||
| }, | |||
| { | |||
| "name":"YEC", | |||
There was a problem hiding this comment.
YEC is the Ycash currency, which is a fork of Zcash.
|
add zcash in the launchsettings and docker-compose.altcoins.yml so when you need to maintain it you can easily run it. |
I kept these in my fork because I didn't want to create any confusion in the main project. But if you prefer, I'll put them in. |
|
yeah, put them in. We already have those in place for altcoins. |
|
Got it. |
|
@hhanh00 question: Is it a regtest in the docker compose? because if that's a container on mainnet, indeed it's better we remove it. If it's on mainnet, I am quite sure nobody will end up maintaining it. |
|
Are you referring to the |
This reverts commit 9ea25d4.
|
Sorry I merged by mistake, can you open this PR again? Can you use regtest rather than mainnet? |
|
I think their regtest does not work anymore. I could use testnet instead... Would you like me to open a new PR? I don't have permissions to reopen this one. |
|
yeah, open a new PR. If no regtest, then remove things from docker-compose and launchsettings. It means that nobody will be able to maintain it, so if it breaks nobody will be able to fix it. That's fine for me, it falls on the zcash community to maintain it. |
|
Where should people contact zcash community if it get broken or if they have questions? |
|
New PR opened: #3400
There are two threads about BTCPayserver: |
The integration of zcash is sponsored by a grant from the zcash major grants: https://grants.zfnd.org/proposals/744682167-payment-gateway-with-btcpay. It includes the development of a wallet / block explorer: https://github.com/hhanh00/zcash-walletd
and this pull request.