Local file system storage as default #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks whether or not a file storage has been set. If not, it sets the local file system storage as default.
dennisreimann
commented
Nov 30, 2022
Comment on lines
-38
to
+46
| DirectoryInfo dirInfo; | ||
| if (!Directory.Exists(datadirs.Value.StorageDir)) | ||
| { | ||
| dirInfo = Directory.CreateDirectory(datadirs.Value.StorageDir); | ||
| } | ||
| else | ||
| { | ||
| dirInfo = new DirectoryInfo(datadirs.Value.StorageDir); | ||
| } | ||
| var dirInfo = Directory.Exists(datadirs.Value.StorageDir) | ||
| ? new DirectoryInfo(datadirs.Value.StorageDir) | ||
| : Directory.CreateDirectory(datadirs.Value.StorageDir); | ||
|
|
||
| if (!Directory.Exists(datadirs.Value.TempDir)) | ||
| { | ||
| Directory.CreateDirectory(datadirs.Value.TempDir); | ||
| } | ||
|
|
||
| DirectoryInfo tmpdirInfo; | ||
| if (!Directory.Exists(datadirs.Value.TempStorageDir)) | ||
| { | ||
| tmpdirInfo = Directory.CreateDirectory(datadirs.Value.TempStorageDir); | ||
| } | ||
| else | ||
| { | ||
| tmpdirInfo = new DirectoryInfo(datadirs.Value.TempStorageDir); | ||
| } | ||
| var tmpdirInfo = Directory.Exists(datadirs.Value.TempStorageDir) | ||
| ? new DirectoryInfo(datadirs.Value.TempStorageDir) | ||
| : Directory.CreateDirectory(datadirs.Value.TempStorageDir); |
There was a problem hiding this comment.
These are just simplifications of the existing code.
|
Concept ack. |
|
The PR is migrating current installs to use file storage provider. |
|
@NicolasDorier Updated as discussed. |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks whether or not a file storage has been set. If not, it sets the local file system storage as default.