Improve domain mapping constraint #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dennisreimann
commented
Feb 10, 2023
dennisreimann
commented
- Fix potential double assignment to appId, leading to an exception
- Add port to redirect, which makes it work in dev env
- Fix potential double assignment to appId, leading to an [exception](https://pastebin.com/j8dhtcTE) - Add port to redirect, which makes it work in dev env
|
Looking forward to this fix. I'm using |
Kukks
approved these changes
Feb 12, 2023
This comment has been minimized.
This comment has been minimized.
Closed
1 task
|
Should we make a release for this one? |
|
@NicolasDorier yes please |
|
will do today @jaonoctus |
|
fixed in 1.7.11 @jaonoctus |
|
I can confirm that this PR fixed the issue. Thank you @dennisreimann @NicolasDorier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.