getrawtransaction should check mempool #26
Labels
Comments
ghost
assigned 
davecgh
added a commit
to btcsuite/btcec
that referenced
this issue
Dec 20, 2013
This commit essentially rewrites all of the primitives needed to perform the arithmetic for ECDSA signature verification of secp256k1 signatures to significantly speed it up. Benchmarking has shown signature verification is roughly 10 times faster with this commit over the previous. In particular, it introduces a new field value which is used to perform the modular field arithmetic using fixed-precision operations specifically tailored for the secp256k1 prime. The field also takes advantage of special properties of the prime for significantly faster modular reduction than is available through generic methods. In addition, the curve point addition and doubling have been optimized minimize the number of field multiplications in favor field squarings since they are quite a bit faster. They routines also now look for certain assumptions such as z values of 1 or equivalent z values which can be used to further reduce the number of multiplicaitons needed when possible. Note there are still quite a few more optimizations that could be done such as using precomputation for ScalarBaseMult, making use of the secp256k1 endomorphism, and using windowed NAF, however this work already offers significant performance improvements. For example, testing 10000 random signature verifications resulted in: New btcec took 15.9821565s Old btcec took 2m34.1016716s Closes btcsuite/btcd#26.
gsalgado
pushed a commit
to gsalgado/btcd
that referenced
this issue
Jul 29, 2014
Fixes btcsuite#26.
davecgh
added a commit
to davecgh/btcd
that referenced
this issue
Feb 19, 2015
This commit implements a reimagining of the way the btcjson package
functions based upon how the project has evolved and lessons learned while
using it since it was first written. It therefore contains significant
changes to the API. For now, it has been implemented in a v2 subdirectory
to prevent breaking existing callers, but the ultimate goal is to update
all callers to use the new version and then to replace the old API with
the new one.
This also removes the need for the btcws completely since those commands
have been rolled in.
The following is an overview of the changes and some reasoning behind why
they were made:
- The infrastructure has been completely changed to be reflection based instead
of requiring thousands and thousands of lines of manual, and therefore error
prone, marshal/unmarshal code
- This makes it much easier to add new commands without making marshalling
mistakes since it is simply a struct definition and a call to register that
new struct (plus a trivial New<foo>Cmd function and tests, of course)
- It also makes it much easier to gain a lot of information from simply
looking at the struct definition which was previously not possible
such as the order of the parameters, which parameters are required
versus optional, and what the default values for optional parameters
are
- Each command now has usage flags associated with them that can be
queried which are intended to allow classification of the commands such
as for chain server and wallet server and websocket-only
- The help infrastructure has been completely redone to provide automatic
generation with caller provided description map and result types. This
is in contrast to the previous method of providing the help directly
which meant it would end up in the binary of anything that imported the
package
- Many of the structs have been renamed to use the terminology from the
JSON-RPC
specification:
- RawCmd/Message is now only a single struct named Request to reflect the fact
it is a JSON-RPC request
- Error is now called RPCError to reflect the fact it is specifically an RPC
error as opposed to many of the other errors that are possible
- All RPC error codes except the standard JSON-RPC 2.0 errors have been
converted from full structs to only codes since an audit of the codebase
has shown that the messages are overridden the vast majority of the time
with specifics (as they should be) and removing them also avoids the
temptation to return non-specific, and therefore not as helpful, error
messages
- There is now an Error which provides a type assertable error with
error codes so callers can better ascertain failure reasons
programatically
- The ID is no longer a part of the command and is instead specified at the time
the command is marshalled into a JSON-RPC request. This aligns better with
the way JSON-RPC functions since it is the caller who manages the ID that is
sent with any given _request_, not the package
- All <Foo>Cmd structs now treat non-pointers as required fields and pointers as
optional fields
- All New<Foo>Cmd functions now accept the exact number of parameters, with
pointers to the appropriate type for optional parameters
- This is preferrable to the old vararg syntax since it means the code will
fail to compile if the optional arguments are changed now which helps
prevent errors creep in over time from missed modifications to optional args
- All of the connection related code has been completely eliminated since this
package is not intended to used a client, rather it is intended to provide
the infrastructure needed to marshal/unmarshal Bitcoin-specific JSON-RPC
requests and replies from static types
- The btcrpcclient package provides a robust client with connection management
and higher-level types that in turn uses the primitives provided by this
package
- Even if the caller does not wish to use btcrpcclient for some reason, they
should still be responsible for connection management since they might want
to use any number of connection features which the package would not
necessarily support
- Synced a few of the commands that have added new optional fields that
have since been added to Bitcoin Core
- Includes all of the commands and notifications that were previously in
btcws
- Now provides 100% test coverage with parallel tests
- The code is completely golint and go vet clean
This has the side effect of addressing nearly everything in, and therefore
closes btcsuite#26.
Also fixes btcsuite#18 and closes btcsuite#19.
davecgh
pushed a commit
to davecgh/btcd
that referenced
this issue
Oct 11, 2017
jrick
added a commit
to jrick/btcd
that referenced
this issue
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
getrawtransaction should check the mempool for transactions as well as the database.
The text was updated successfully, but these errors were encountered: