rpcclient: send legacy GetBlock request for backwards compatibility #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Needs a rebase with the dependent PR merged. |
|
@Roasbeef done. |
Roasbeef
requested changes
May 15, 2020
There was a problem hiding this comment.
Nice work around! We should also follow up on the lnd side with a PR that updates our CI to point against btcd master (temporarily) to make sure it works in our context as well.
In the end, I think putting some effort into the abstract HTTP-only client would allow us to keep up with the bitcoind changes for those users that use the rpcclient to interact with bitcoidn primarily, yet allow us to not have to break base btcd functionality.
Without this, users of this library wouldn't be able to issue GetBlock requests to nodes which haven't updated to support the latest request format, namely the use of a single `int` parameter to denote verbosity instead of two `bool`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, users of this library wouldn't be able to issue GetBlock requests to nodes which haven't updated to support the latest request format, namely the use of a single
intparameter to denote verbosity instead of twobools.I've confirmed through manual testing that these changes, along with #1560, provide full compatibility for bitcoind and btcd and provide backwards compatibility for btcd.