Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: Add GetTransactionWatchOnly method #1592

Merged
merged 1 commit into from
Jun 29, 2020
Merged

rpcclient: Add GetTransactionWatchOnly method #1592

merged 1 commit into from
Jun 29, 2020

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented Jun 10, 2020

Adding GetTransactionWatchOnlyAsync and GetTransactionWatchOnly methods, to support passing the include_watchonly argument to gettransaction.

The method signature is following ListTransactionsCountFromWatchOnly (soon to be merged), as discussed in #1589.

lindlof
lindlof approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@lindlof lindlof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Rjected
Rjected approved these changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌀

jcvernaleo
jcvernaleo approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit e2d9cf4 into btcsuite:master Jun 29, 2020
@onyb onyb deleted the gettransaction-watchonly branch July 7, 2020 09:49
@onyb onyb mentioned this pull request Jul 10, 2020
Closed
@onyb onyb mentioned this pull request Sep 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@lindlof lindlof lindlof approved these changes

@jakesylvestre jakesylvestre jakesylvestre approved these changes

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onyb @jcvernaleo @lindlof @jakesylvestre @Rjected