peer: use generic lru #1599
Merged
peer: use generic lru #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyb
reviewed
Jul 7, 2020
davecgh
reviewed
Jul 7, 2020
|
I don't see anything wrong with using dcrd modules. Modules are stable and can be used by callers as desired. |
onyb
approved these changes
Jul 7, 2020
|
@davecgh did you have any objections of than the go mod tidy (which was done)? If not I'm going to merge this one. |
|
Since there seemed to be no objections and this is important, merging it in now. |
|
Actually, @tuxcanfly could you squash this to one commit before I merge? |
|
I didn't test it, but it reads well enough. |
|
Will give it a quick test |
tuxcanfly
force-pushed
the
use-generic-lru
branch
from
847835e
to
a21879e
Compare
|
Squashed 👍 |
jakesylvestre
approved these changes
Jul 8, 2020
|
Just a sec, borrowing some updates from @dajohi |
While here, also rename and generalize limitMap and apply to other maps which need to be bounded.
|
@tuxcanfly just squash it when you are ready for final review/merge/ |
tuxcanfly
force-pushed
the
use-generic-lru
branch
from
5f21fe3
to
4b3f7f3
Compare
tuxcanfly
commented
Jul 8, 2020
| @@ -147,6 +147,25 @@ type peerSyncState struct { | |||
| requestedBlocks map[chainhash.Hash]struct{} | |||
| } | |||
|
|
|||
| // limitAdd is a helper function for maps that require a maximum limit by | |||
There was a problem hiding this comment.
Does anyone object to this func name? It's called addAndLimitMap in @dajohi code but I thought it was too verbose.
|
Squashed again. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
sentNoncesandknownInventoryto use the more generic LRU from Decred. This cuts down the need for maintaining two instances of almost same code i.emruInventoryMapandmruSentNonces.