Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: handle notfound #1603

Merged
merged 1 commit into from
Jul 28, 2020
Merged

server: handle notfound #1603

merged 1 commit into from
Jul 28, 2020

Conversation

tuxcanfly
Copy link
Contributor

Also, increase ban score on notfound and return whether addBanScore disconnects the peer. Backport from decred/dcrd#2253

@Rjected Rjected added this to In progress in btcd-dev Jul 17, 2020
jcvernaleo
jcvernaleo requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment change needed but looks good.

Also could you squash this and in the commit message mention that it was backported from decred rather than only have that info in the github comment.

netsync/manager.go Outdated Show resolved Hide resolved
btcd-dev automation moved this from In progress to Review in progress Jul 27, 2020
@tuxcanfly
netsync: handle notfound messages from peers
e7d0303 
backport from decred/dcrd#2253

When a peer sends a notfound message, remove the hash from requested
map.  Also increase notfound ban score and return early if it
disconnects the peer.
jcvernaleo
jcvernaleo approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

btcd-dev automation moved this from Review in progress to Reviewer approved Jul 28, 2020
@jcvernaleo jcvernaleo merged commit 24db7d7 into btcsuite:master Jul 28, 2020
btcd-dev automation moved this from Reviewer approved to Done Jul 28, 2020
@onyb onyb mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
btcd-dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tuxcanfly @jcvernaleo