Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wire.Outpoint parser from string #1879

Merged
merged 2 commits into from
May 25, 2023
Merged

Add wire.Outpoint parser from string #1879

merged 2 commits into from
May 25, 2023

Conversation

GeorgeTsagk
Copy link
Contributor

  • Adds NewOutPointFromString function in wire package.
  • Adds unit tests for NewOutPointFromString

guggero
guggero reviewed Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Definitely nice to have that in the wire package directly.

wire/msgtx.go Outdated Show resolved Hide resolved
wire/msgtx_test.go Outdated Show resolved Hide resolved
wire/msgtx_test.go Outdated Show resolved Hide resolved
@GeorgeTsagk
Copy link
Contributor Author

@guggero
Also added a new test case named big index outpoint, which includes a tx index which is a bit higher than the max int32 value.

guggero
guggero approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

bhandras
bhandras reviewed Aug 16, 2022
View reviewed changes
wire/msgtx.go Outdated Show resolved Hide resolved
wire/msgtx_test.go Outdated Show resolved Hide resolved
bhandras
bhandras approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small nits remain, otherwise LGTM 🎉

wire/msgtx_test.go Outdated Show resolved Hide resolved
wire/msgtx_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2868576184

  • 13 of 17 (76.47%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 55.143%
Changes Missing Coverage Covered Lines Changed/Added Lines %
wire/msgtx.go 13 17 76.47%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
Totals Coverage Status
Change from base Build 2836573928: 0.01%
Covered Lines: 26533
Relevant Lines: 48117
💛 - Coveralls

Roasbeef
Roasbeef approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@Roasbeef Roasbeef merged commit 9c16d23 into btcsuite:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GeorgeTsagk @coveralls @bhandras @Roasbeef @guggero