Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance code comments #2074

Merged
merged 2 commits into from Dec 19, 2023
Merged

fix: enhance code comments #2074

merged 2 commits into from Dec 19, 2023

Conversation

threewebcode
Copy link
Contributor

@threewebcode threewebcode commented Dec 16, 2023

Enhance and tidy the code comments

@threewebcode
Copy link
Contributor Author

@davecgh, Please help review

@coveralls
Copy link

coveralls commented Dec 16, 2023

Pull Request Test Coverage Report for Build 7256586442

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 999 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.6%) to 56.622%

Files with Coverage Reduction New Missed Lines %
peer/peer.go 1 74.52%
netsync/blocklogger.go 9 0.0%
database/ffldb/db.go 25 91.67%
btcutil/gcs/builder/builder.go 28 68.04%
server.go 60 0.0%
blockchain/utxoviewpoint.go 93 73.76%
blockchain/chainio.go 170 61.25%
netsync/manager.go 187 0.0%
config.go 204 5.09%
blockchain/chain.go 222 73.38%
Totals Coverage Status
Change from base Build 7227596643: 0.6%
Covered Lines: 28618
Relevant Lines: 50542

💛 - Coveralls

@threewebcode
Copy link
Contributor Author

@davecgh, Please help review

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change is good, I'd rather you revert the other one.

mining/mining.go Show resolved Hide resolved
mining/mining.go Outdated Show resolved Hide resolved
Remove unnecessary words
@threewebcode
Copy link
Contributor Author

@jcvernaleo The change set is updated with your review. Please take a look again.

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo
Copy link
Member

@threewebcode I forgot to allow the github actions to run. Once those finish I'll merge.

@jcvernaleo jcvernaleo merged commit b2f340d into btcsuite:master Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants