blockchain: Remove unneeded unspentness size check. #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is needlessly checking the number of bytes needed to serialize the unspentness bitmap in the utxo against a maximum value that could never be returned because the function takes a uint32 output index which is treated as a bit offset, and converts it bytes, which will necessarily be less than a max uint32. This check also causes a compile error on arm where native integers are 32 bits. This simply removes the unneeded check.
|
OK |
|
@T909 Would you confirm this resolves your issue as well? |
|
Yup, compiles now, thanks! (also... getting a crash now when running it on arm, but that's a different issue; |
|
Thanks for testing. |
cjepson
pushed a commit
to cjepson/btcd
that referenced
this pull request
Sep 21, 2016
The current code is needlessly checking the number of bytes needed to serialize the unspentness bitmap in the utxo against a maximum value that could never be returned because the function takes a uint32 output index which is treated as a bit offset, and converts it bytes, which will necessarily be less than a max uint32. This check also causes a compile error on arm where native integers are 32 bits. This simply removes the unneeded check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is needlessly checking the number of bytes needed to serialize the unspentness bitmap in the utxo against a maximum value that could never be returned because the function takes a
uint32output index which is treated as a bit offset, and converts it bytes, which will necessarily be less than a maxuint32.This check also causes a compile error on arm where native integers are 32 bits.
This simply removes the unneeded check.
Fixes #664.
This change is