wire: Use large tx for deserialize benchmark. #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
wire_large_bench_tx
branch
from
062b685
to
a092f16
Compare
| @@ -306,7 +308,7 @@ func BenchmarkWriteTxIn(b *testing.B) { | |||
| } | |||
|
|
|||
| // BenchmarkDeserializeTx performs a benchmark on how long it takes to | |||
| // deserialize a transaction. | |||
| // deserialize a small transaction. | |||
| func BenchmarkDeserializeTx(b *testing.B) { | |||
There was a problem hiding this comment.
Can we add Small here as well to match?
This adds a benchmark for deserializing a large transaction that is often referred to as the megatransaction since it is the largest Bitcoin transaction mined to date. It consists of 5569 inputs and 1 output and its hash is: bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08. This is being done so there is a benchmark that tests more of a worst-case scenario which is a better candidate for identifying and testing improvements. The following benchmark results shows the how much more intensive this transaction is over the existing mock transaction: DeserializeTxSmall 1000000 1751 ns/op 376 B/op 16 allocs/op DeserializeTxLarge 300 5093980 ns/op 1672829 B/op 33430 allocs/op
davecgh
force-pushed
the
wire_large_bench_tx
branch
from
a092f16
to
ec7d9b5
Compare
|
ok |
cjepson
pushed a commit
to cjepson/btcd
that referenced
this pull request
Sep 21, 2016
This adds a benchmark for deserializing a large transaction that is often referred to as the megatransaction since it is the largest Bitcoin transaction mined to date. It consists of 5569 inputs and 1 output and its hash is: bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08. This is being done so there is a benchmark that tests more of a worst-case scenario which is a better candidate for identifying and testing improvements. The following benchmark results shows the how much more intensive this transaction is over the existing mock transaction: DeserializeTxSmall 1000000 1751 ns/op 376 B/op 16 allocs/op DeserializeTxLarge 300 5093980 ns/op 1672829 B/op 33430 allocs/op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a benchmark for deserializing a large transaction that is often referred to as the megatransaction since it is the largest Bitcoin transaction mined to date.
It consists of 5569 inputs and 1 output and its hash is:
bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08.
This is being done so there is a benchmark that tests more of a worst-case scenario which is a better candidate for identifying and testing improvements.
The following benchmark results shows the how much more intensive this transaction is over the existing mock transaction: