wire: Don't allocate new readers in benchmarks. #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
wire_update_benchmarks
branch
2 times, most recently
from
9aa9706
to
6d60518
Compare
|
ok |
This modifies the benchmarks in the wire package to avoid creating a new reader for each iteration. This is useful since it means that showing the memory allocations will only show the function under test instead of the allocation for the benchmark setup as well. The following is a before and after comparison of the allocations with the benchmarks that did not change removed: benchmark old allocs new allocs delta ------------------------------------------------------------ ReadVarInt1 2 1 -50.00% ReadVarInt3 2 1 -50.00% ReadVarInt5 2 1 -50.00% ReadVarInt9 2 1 -50.00% ReadVarStr4 4 3 -25.00% ReadVarStr10 4 3 -25.00% ReadOutPoint 2 1 -50.00% ReadTxOut 4 3 -25.00% ReadTxIn 6 5 -16.67% DeserializeTxSmall 16 15 -6.25% DeserializeTxLarge 33430 33428 -0.01% ReadBlockHeader 8 7 -12.50%
davecgh
force-pushed
the
wire_update_benchmarks
branch
from
6d60518
to
fe5f9e1
Compare
cjepson
pushed a commit
to cjepson/btcd
that referenced
this pull request
Sep 21, 2016
This modifies the benchmarks in the wire package to avoid creating a new reader for each iteration. This is useful since it means that showing the memory allocations will only show the function under test instead of the allocation for the benchmark setup as well. The following is a before and after comparison of the allocations with the benchmarks that did not change removed: benchmark old allocs new allocs delta ------------------------------------------------------------ ReadVarInt1 2 1 -50.00% ReadVarInt3 2 1 -50.00% ReadVarInt5 2 1 -50.00% ReadVarInt9 2 1 -50.00% ReadVarStr4 4 3 -25.00% ReadVarStr10 4 3 -25.00% ReadOutPoint 2 1 -50.00% ReadTxOut 4 3 -25.00% ReadTxIn 6 5 -16.67% DeserializeTxSmall 16 15 -6.25% DeserializeTxLarge 33430 33428 -0.01% ReadBlockHeader 8 7 -12.50%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This requires #678 in order for the reported allocation statistics to be correct.
This modifies the benchmarks in the wire package to avoid creating a new reader for each iteration. This is useful since it means that showing the memory allocations will only show the function under test instead of the allocation for the benchmark setup as well.
The following is a before and after comparison of the allocations with the benchmarks that did not change removed: