hdkeychain: extend API with ChainCode(), ChildNum() #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyb
reviewed
May 19, 2020
onyb
reviewed
May 19, 2020
onyb
suggested changes
May 19, 2020
No way to access them otherwise. Handy for interoperability.
onyb
reviewed
May 20, 2020
| childNum := key.ChildNum() | ||
| if childNum != test.childNum { | ||
| t.Errorf("ChildNum #%d (%s): want %d, got %d", i, | ||
| test.name, childNum, test.childNum) |
There was a problem hiding this comment.
It seems the "want" and "got" are flipped.
Suggested change
| test.name, childNum, test.childNum) | |
| test.name, test.childNum, childNum) |
onyb
reviewed
May 20, 2020
| chainCode := key.ChainCode() | ||
| if !bytes.Equal(chainCode, test.chainCode) { | ||
| t.Errorf("ChainCode #%d (%s): want %v, got %v", i, | ||
| test.name, chainCode, test.chainCode) |
There was a problem hiding this comment.
Same as with ChildNum().
Suggested change
| test.name, chainCode, test.chainCode) | |
| test.name, test.chainCode, chainCode) |
Roasbeef
requested changes
Jun 22, 2020
| // ChainCode returns the chain code part of this extended key. | ||
| // | ||
| // It is identical for both public and private extended keys. | ||
| func (k *ExtendedKey) ChainCode() []byte { |
There was a problem hiding this comment.
With #171 merged, we can reduce this PR to just adding the chain code.
|
Closing since we merged new version of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No way to access them otherwise. Handy for interoperability.