Open option doesn't end build process

[vladshcherbin]

When { open: true } is used, stats file is opened in a browser, but the build process doesn't end.

Similar issue - #17 (comment)

I've updated test repo to reflect this issue.

node - 11.7.0
macOS - 10.13.4

[btd]

Why it should end build? вс, 24 февр. 2019 г., 19:40 Vlad Shcherbin <notifications@github.com>:

…

When { open: true } is used, stats file is opened in a browser, but the build process doesn't end. Similar issue - #17 (comment) <#17 (comment)> I've updated test repo <https://github.com/vladshcherbin/experiments/tree/master/visualizer> to reflect this issue. node - 11.7.0 macOS - 10.13.4 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#27>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUcA3JZIx6prrKD2E-DCPNCJ3li7RBKks5vQsCJgaJpZM4bOoUq> .

[vladshcherbin]

@btd why wouldn't it? I thought it would create stats (as default) and just open a browser to see them.

If I don't want to end build I'd use watch option, no?

[btd]

Well, maybe, not sure. But how in this case plugin should detect if it is running in watch mode and do not stop build?

[vladshcherbin]

@btd you can check, if rollup is in watch mode by using process.env.ROLLUP_WATCH, it will be true

I found it recently and opened an issue as it's not in the docs

[btd]

ok, so it looks i can add option like throwOnOpen. i do not want to add process.exit because it will exit whole process, even if plugin used programatically (i use at least in this way). This way i do not need to care about ROLLUP_WATCH

[vladshcherbin]

@btd let's don't rush it and find a good solution.

can you describe a bit how you use it and why do you need it to stay open? maybe watch can help somehow? tell about it, I might be missing the purpose :)

[btd]

@vladshcherbin i do not use watch, because rollup is only one part of whole build process.

[btd]

Closing because of lack of interest