-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--unanimous tests (contains all commits from, and supersedes, #35) #37
Conversation
…l hosts agree. Otherwise, exit(1) and show output as usual. Resolves bterlson#22
…ilijev-quorum * 'quorum' of https://github.com/dilijev/eshost-cli: Rename `--quorum, -q` to `--unanimous, -u` Resolve bterlson#22: `--quorum` will exit(0) and output nothing if all hosts agree.
c780d8a
to
516e400
Compare
|
516e400
to
60770c0
Compare
let found = false; | ||
|
||
for (let row of table) { | ||
if (row[1] === result) { | ||
for (let record of records) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not always be a "table", and the default reporter shouldn't be talking about tables anyway ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to justify your style fixes :-P
Travis worked wonderfully, btw: https://travis-ci.org/bterlson/eshost-cli/builds/267687347 |
@rwaldron Sorry for dragging my feet on the tests. Thanks for the updates and for adding the tests! |
--unanimous
will exit(0) and output nothing if all hosts agree. #35 with necessary fixes to:--unanimous