--unanimous tests (contains all commits from, and supersedes, #35) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l hosts agree. Otherwise, exit(1) and show output as usual. Resolves bterlson#22
…ilijev-quorum * 'quorum' of https://github.com/dilijev/eshost-cli: Rename `--quorum, -q` to `--unanimous, -u` Resolve bterlson#22: `--quorum` will exit(0) and output nothing if all hosts agree.
rwaldron
force-pushed
the
unanimous-tests
branch
2 times, most recently
from
c780d8a
to
516e400
Compare
|
|
rwaldron
force-pushed
the
unanimous-tests
branch
from
516e400
to
60770c0
Compare
rwaldron
changed the title
rwaldron
commented
Aug 23, 2017
| let found = false; | ||
|
|
||
| for (let row of table) { | ||
| if (row[1] === result) { | ||
| for (let record of records) { |
There was a problem hiding this comment.
This might not always be a "table", and the default reporter shouldn't be talking about tables anyway ;)
There was a problem hiding this comment.
You don't need to justify your style fixes :-P
|
Travis worked wonderfully, btw: https://travis-ci.org/bterlson/eshost-cli/builds/267687347 |
|
@rwaldron Sorry for dragging my feet on the tests. Thanks for the updates and for adding the tests! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--unanimouswill exit(0) and output nothing if all hosts agree. #35 with necessary fixes to:--unanimous