Post individual comments when possible #82
Conversation
|
|
||
| @Override | ||
| public void onResponse(final Call<T> call, final Response<T> response) { | ||
| // This method intentionally left blank. |
There was a problem hiding this comment.
Could log more info here, but as I said above, was not receiving any responses to inline comment POSTs anyway...
|
@btkelly this is ready for review! |
|
Comments like this (same file, line number) could be consolidated. Can either do that in this PR or open a follow-up issue. Would improve performance also. |
|
Follow-up issue: avoid duplicating comments on subsequent CI builds (need to be careful about this + understand how it impacts comments being marked as outdated). |
|
|
||
| violationsWithValidLocationInfo.sort(Violation.COMMENT_POSTING_COMPARATOR); | ||
|
|
||
| violationsWithValidLocationInfo.stream() |
There was a problem hiding this comment.
It's like rxJava; just have to avoid overuse :P
|
@stkent I love it! Only request would be to update the README screenshot to show the line commenting instead of the aggregated comments. |
|
Good call; on it! |
|
@btkelly updated |
Fixes #34, Fixes #67
This is the PR I've been testing on:
https://github.com/stkent/gnag-testing/pull/1
It includes a subset of the files from the gnag example project. In particular, this allows testing of the following scenarios: