use the vector graphics version of the logo #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PDF generated from the SVG is used. If this is not available / does not work, the PNG file is automatically used. The SVG is not used directly for the case that users of the framework do not have inkscape installed. If users still want to edit or replace the SVG file, it is included and the corresponding command can be commented in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Vector graphics are more suitable for logos than raster graphics. I therefore suggest replacing the logo on the header.
Solution
Because not everyone has Inkscape installed, I am attaching a PDF file that was created from the SVG. If this is not available for some reason, the PNG file is automatically used. If users still want to edit or replace the SVG file, it is included and the corresponding command can be commented in. Therefore, general SVG support is now added. For this purpose, the
--shell-escapeparameter was added to the Makefile for building the file.