Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Windows compatibility #14

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

HannesLueer
Copy link
Contributor

I've made updates to the Makefile to enable compatibility with Windows environments. Now, the build process should work on Windows. This should fix issue #11.

Note my suggestions from pull request #9 and #10. If all are accepted there will be conflicts with the Makefile as they have been changed differently. In the new Makefile version only bibtex has to be replaced by biber, to merge #10. Regarding #9, I have already added the --shell-escape parameter to pdflatex as it does not break anything.

@btoschek
Copy link
Owner

I don't think we should add the --shell-escape parameter when it's currently not needed. Security-wise this enables packages to run arbitrary commands through pdflatex, which poses a significant risk from malicious packages to the end user's system. I'll update your PR and merge. Thanks for the speedy PR.

@btoschek btoschek merged commit 79ca10b into btoschek:makefile-rework Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants