Skip to content

Commit

Permalink
The fix for bitfield in r59 wasn't quite correct. Instead of
Browse files Browse the repository at this point in the history
being sent too early it could now be sent too late.

Change version to 0.5 and document the bug fix.
  • Loading branch information
rmn64k committed Aug 2, 2005
1 parent 8115e48 commit e485377
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGES
@@ -1,3 +1,10 @@
btpd-0.5:
---------

Bug fixes:
- The bitfield could be sent too late. This could cause the receiving
peer to close the connection.

btpd-0.4:
---------

Expand Down
2 changes: 1 addition & 1 deletion btpd/net.c
Expand Up @@ -788,14 +788,14 @@ net_shake_read(struct peer *p, unsigned long rmax)
btpd_log(BTPD_L_CONN, "Got whole shake.\n");
free(hs);
p->piece_field = btpd_calloc(1, (int)ceil(p->tp->meta.npieces / 8.0));
cm_on_new_peer(p);
net_generic_reader(p);
if (p->tp->have_npieces > 0) {
if (p->tp->have_npieces * 9 < 5 + ceil(p->tp->meta.npieces / 8.0))
net_send_multihave(p);
else
net_send_bitfield(p);
}
cm_on_new_peer(p);
} else
event_add(&p->in_ev, NULL);

Expand Down
2 changes: 1 addition & 1 deletion configure.ac
@@ -1,4 +1,4 @@
AC_INIT(btpd, 0.4, btpd@murmeldjur.se)
AC_INIT(btpd, 0.5, btpd@murmeldjur.se)

AC_CANONICAL_TARGET

Expand Down

0 comments on commit e485377

Please sign in to comment.