Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'btracec' mistakenly marks a particular call as unsafe #222

Closed
jbachorik opened this issue May 1, 2016 · 1 comment
Closed

'btracec' mistakenly marks a particular call as unsafe #222

jbachorik opened this issue May 1, 2016 · 1 comment
Assignees
@jbachorik
Labels
BTRACE bug Compiler
Milestone
1.3.7

Comments

@jbachorik
Copy link
Collaborator

When the script contains Sys.Memory.getMemoryPoolUsage(str(sb)) call the compilation will fail because it mistakenly considered as an unsafe outgoing method call.
@jbachorik jbachorik self-assigned this May 1, 2016
@jbachorik jbachorik added this to the 1.3.7 milestone May 1, 2016
@jbachorik jbachorik added Compiler and removed Core labels May 1, 2016
@jbachorik
Copy link
Collaborator Author

jbachorik commented May 8, 2016 •
edited
Loading

This is caused by the verifier still relying on Java 6 APIs mostly and missing the fact that Sys.Memory is an inner class of BTraceUtils. For an immediate remedy one can simply use BTraceUtils.Sys.Memory.getMemoryPoolUsage(). A long term fix is to use the Java 7 javax.lang.model.element API which can provide much more precise data.

jbachorik added a commit that referenced this issue May 9, 2016
@jbachorik
#222 followup fix for JDK 7
c27694a
jbachorik added a commit that referenced this issue May 9, 2016
@jbachorik
Use 'javax.lang.model.element' API to check for proper method calls
2b009c4 
Fixes #222
Fixes #223
jbachorik added a commit that referenced this issue May 9, 2016
@jbachorik
#222 followup fix for JDK 7
1cbbebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbachorik jbachorik

Labels
BTRACE bug Compiler
Projects
None yet
Milestone
1.3.7
Development

No branches or pull requests
1 participant
@jbachorik