Expand test to cover incorrect file extension

btreeby · Jun 4, 2023 · d02991a · d02991a
1 parent c6651d4
commit d02991a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/+h5tools/private/mustBeH5File.m b/+h5tools/private/mustBeH5File.m
@@ -16,7 +16,7 @@ function mustBeH5File(filename)
 
 [~, ~, ext] = fileparts(filename);
 if ~strcmp(ext, '.h5')
-    eid = 'Filename:wrongExtension';
+    eid = 'h5tools:wrongExtension';
     msg = 'Filename must have .h5 extension.';
     throwAsCaller(MException(eid, msg));
 end
diff --git a/tests/test_copyGroup.m b/tests/test_copyGroup.m
@@ -10,6 +10,7 @@
     properties
         fromFile = 'testFrom.h5';
         toFile = 'testTo.h5';
+        textFile = 'textFile.txt';
 
         groupFile1 = 'testGroup1';
         datasetFile1 = 'testDataset1'
@@ -24,7 +25,8 @@
     
     methods (TestMethodSetup)
 
-        % Create two HDF5 files, both containing a group with a dataset.
+        % Create two HDF5 files, both containing a group with a dataset,
+        % and a text file.
         function createH5Files(testCase)
             testCase.dataFile1 = rand(testCase.dimsFile1);
             testCase.dataFile2 = rand(testCase.dimsFile2);
@@ -34,6 +36,8 @@ function createH5Files(testCase)
 
             h5create(testCase.toFile, ['/' testCase.groupFile2 '/' testCase.datasetFile2], testCase.dimsFile2);
             h5write(testCase.toFile, ['/' testCase.groupFile2 '/' testCase.datasetFile2], testCase.dataFile2);
+
+            writelines("Hello world", testCase.textFile);
         end
 
     end
@@ -44,6 +48,7 @@ function createH5Files(testCase)
         function deleteH5Files(testCase)
             delete(testCase.fromFile);
             delete(testCase.toFile);
+            delete(testCase.textFile);
         end
 
     end
@@ -54,10 +59,16 @@ function deleteH5Files(testCase)
         % dataset is correct.
         function testValidInput(testCase)
             h5tools.copyGroup(testCase.fromFile, testCase.toFile, testCase.groupFile1);
-
             dataOut = h5read(testCase.toFile, ['/' testCase.groupFile1 '/' testCase.datasetFile1]);
             testCase.verifyEqual(dataOut, testCase.dataFile1);
         end
+
+        % Copy a dataset with the wrong extension.
+        function testInvalidInput(testCase)
+            testCase.verifyError( ...
+                @() h5tools.copyGroup(testCase.fromFile, testCase.textFile, testCase.groupFile1), ...
+                'h5tools:wrongExtension');
+        end
 
     end