-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/autoprefixer #210
Merged
Merged
Feature/autoprefixer #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help monitor the total file-size. In the next commit, autoprefixer will be added, and it will be useful to see if the package is taking any effect. Note: This may be removed if tracking compiled CSS files becomes too noisy. Its more for testing purposes at this moment in time.
## Changes: - Adds autoprefixer (https://github.com/nDmitry/grunt-postcss and https://github.com/postcss/autoprefixer). - Adds postcss task. - Adds the postcss task to the watch task for sass, so it is run anytime sass task is run. - Recompiles the sass. Note the changes in the compiled CSS files below. ## Properties that were added: - -webkit-text-decoration - -o-object-fit - New transition syntax: - transition: -webkit-transform - transition: transform - transition: transform, -webkit-transform ## Properties that were removed: - -moz-box-sizing - -webkit-box-sizing - background-image: -webkit-gradient - background-image: -webkit-linear-gradient - background-image: -moz-linear-gradient - background-image: -ms-linear-gradient - background-image: -o-linear-gradient - -webkit-border-radius - -moz-border-radius - -ms-border-radius - -webkit-transition - -moz-transition - -ms-transition - -o-transition - -moz-transform - -ms-transform - -o-transform - -o-min-device-pixel-ratio
Since autoprefixer is adding prefixes, we’ll need to run its sourcemap function on top of the compiled sass sourcemaps. Sass => compiled CSS file that maps back to Sass => PostCSS => updates compiled CSS file that maps back to non-autoprefixed CSS to Sass
I've confirmed IE10 would be considered dead by our analytics as well at this point. I can answer some of these questions:
|
ashleykolodziej
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything appears to be working to me. Thanks for taking the lead on this! ⭐️
This was referenced Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature,
autoprefixer
, which was brought up in #204. See this Issue for background on howautoprefixer
can help our front-end workflow and establish concrete browser support for projects.Changes
autoprefixer
withgrunt-postcss
package.gitignore
file.Gruntfile.js
to apply Post CSS transforms on the compileddocs/css/docs.css
file as well as the newcss/burf-theme.css
andcss/burf-base.css
files.Notes
Configuration and Browser Support
Looks like the
browserslist
config inpackage.json
:supports these browsers:
^ Info obtained by doing a
console.log( autoprefixer.info() );
in the Gruntfile.IE 10
is left out because it isfalse
for thenot dead
query^ https://github.com/browserslist/browserslist#full-list
The cool thing about this config is that the list of browsers will change dynamically for us. As the older browsers die off, this configuration will update the browser versions supported without us needing to touch anything.
The other cool thing is that
babel-preset-env
is reading from the samebrowserslist
config thatautoprefixer
is using, so it centralizes the intended browser support to one location and multiple tools can consume the same browser configurations.Properties that were added:
Properties that were removed:
Next steps
css/burf-theme.css
andcss/burf-base.css
in the repo.autoprefixer
can do its job listening to thebrowserslist
config defined inpackage.json
.