-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/autoprefixer #50
Conversation
Note: Code Climate issues for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you take care of the build task edit below and also add a note that with this release, there is a significant change to browser support out of the box, and a way to find out what browsers are supported? Some projects with older SOWs may want to start with a previous version of child starter for browser support reasons. Or, alternately, add some documentation for how to edit the browser support list.
Gruntfile.js
Outdated
autoprefixer, // add vendor prefixes. | ||
], | ||
}, | ||
src: ['ie.css', 'ie.min.css', 'style.css', 'style.min.css'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually want to run postcss on IE stylesheets? They're only loaded on old versions of IE that support the conditional comment syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glace I figured I'd add it in, but this is a good point. After looking further into it, the IE stylesheets seem to be loaded in addition to the regular stylesheet, so the postcss transforms could increase filesize.
Co-Authored-By: toddmilliken <milliktr@gmail.com>
IE stylesheets are added in addition to the global stylesheet. They shouldn’t need postcss transforms since they only support IE8 or less.
Added a new page to Framework wiki for configuring browser support: https://github.com/bu-ist/responsive-framework/wiki/Browser-Support |
…starter into feature/autoprefixer # Conflicts: # CHANGELOG.md # Gruntfile.js # ie.css.map # ie.min.css.map # languages/responsive-child-starter.pot # package-lock.json # package.json # style.css.map # style.min.css.map
Adds a new feature,
autoprefixer
, which was brought up in Foundation issue bu-ist/responsive-foundation#204 and executed in Foundation PR bu-ist/responsive-foundation#210. View those links for background on howautoprefixer
can help our front-end workflow and establish concrete browser support for projects.Changes
autoprefixer
withgrunt-postcss
packageGruntfile.js
to apply Post CSS transforms on the compiled admin, ie, styles CSS files.Companion PRs
Review checklist
CHANGELOG.MD
with a brief explanation of the changes in this pull request in the unreleased section.