Feature/autoprefixer #50
Conversation
|
Note: Code Climate issues for |
There was a problem hiding this comment.
Looks good. Can you take care of the build task edit below and also add a note that with this release, there is a significant change to browser support out of the box, and a way to find out what browsers are supported? Some projects with older SOWs may want to start with a previous version of child starter for browser support reasons. Or, alternately, add some documentation for how to edit the browser support list.
Gruntfile.js
Outdated
| autoprefixer, // add vendor prefixes. | ||
| ], | ||
| }, | ||
| src: ['ie.css', 'ie.min.css', 'style.css', 'style.min.css'], |
There was a problem hiding this comment.
Do we actually want to run postcss on IE stylesheets? They're only loaded on old versions of IE that support the conditional comment syntax.
There was a problem hiding this comment.
At first glace I figured I'd add it in, but this is a good point. After looking further into it, the IE stylesheets seem to be loaded in addition to the regular stylesheet, so the postcss transforms could increase filesize.
Co-Authored-By: toddmilliken <milliktr@gmail.com>
IE stylesheets are added in addition to the global stylesheet. They shouldn’t need postcss transforms since they only support IE8 or less.
|
Added a new page to Framework wiki for configuring browser support: https://github.com/bu-ist/responsive-framework/wiki/Browser-Support |
…starter into feature/autoprefixer # Conflicts: # CHANGELOG.md # Gruntfile.js # ie.css.map # ie.min.css.map # languages/responsive-child-starter.pot # package-lock.json # package.json # style.css.map # style.min.css.map
Adds a new feature,
autoprefixer, which was brought up in Foundation issue bu-ist/responsive-foundation#204 and executed in Foundation PR bu-ist/responsive-foundation#210. View those links for background on howautoprefixercan help our front-end workflow and establish concrete browser support for projects.Changes
autoprefixerwithgrunt-postcsspackageGruntfile.jsto apply Post CSS transforms on the compiled admin, ie, styles CSS files.Companion PRs
Review checklist
CHANGELOG.MDwith a brief explanation of the changes in this pull request in the unreleased section.