Support dynamic import #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamic import support has just landed in [Rollup 0.55.0](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#upcoming-0550). When testing a project that uses buble via rollup-plugin-buble, I noticed that it doesn't support dynamic import yet, resulting in the error ``` SyntaxError: Unexpected token in ... ``` Looking at the [rollup source code](https://github.com/rollup/rollup/blob/089c9e06190b894d766fc44571752fa91dc1eaa5/src/Graph.ts#L3), I see that they are using [acorn-dynamic-import](https://github.com/kesne/acorn-dynamic-import). This pull request therefore adds the acorn-dynamic-import plugin as done in rollup itself so that buble is able to parse code that uses dynamic import. I've also created a small test file that fails without these changes. Let me know if it's enought or if I should write more tests.
oligot
added a commit
to oligot/nodent-compiler
that referenced
this pull request
Jan 25, 2018
[dynamic import](https://github.com/tc39/proposal-dynamic-import) support has just landed in [Rollup 0.55.0](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#upcoming-0550). When testing a project that uses nodent via [rollup-plugin-nodent](https://github.com/oligot/rollup-plugin-nodent), I noticed that it doesn't support dynamic import yet, resulting in the error ``` SyntaxError: Unexpected token in ... ``` Looking at the [rollup source code](https://github.com/rollup/rollup/blob/089c9e06190b894d766fc44571752fa91dc1eaa5/src/Graph.ts#L3), I see that they are using [acorn-dynamic-import](https://github.com/kesne/acorn-dynamic-import). This pull request therefore adds the acorn-dynamic-import plugin as done in rollup itself so that the nodent compiler is able to parse code that uses dynamic import. This is quite similar to what has been done for [buble](bublejs/buble#102).
oligot
added a commit
to oligot/rollup-plugin-nodent
that referenced
this pull request
Jan 25, 2018
[dynamic import](https://github.com/tc39/proposal-dynamic-import) support has just landed in [Rollup 0.55.0](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#upcoming-0550). When testing a project that uses nodent via rollup-plugin-nodent, I noticed that it doesn't support dynamic import yet, resulting in the error ``` SyntaxError: Unexpected token in ... ``` Looking at the [rollup source code](https://github.com/rollup/rollup/blob/089c9e06190b894d766fc44571752fa91dc1eaa5/src/Graph.ts#L3), I see that they are using [acorn-dynamic-import](https://github.com/kesne/acorn-dynamic-import). This patches the acorn version that is used in nodent to add the acorn-dynamic-import plugin as done in rollup itself. That way, the nodent compiler is able to parse code that uses dynamic import. This is quite similar to what has been done for [buble](bublejs/buble#102). Also switch from xo to eslint and eslint-config/plugin-*
|
Great, thanks for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamic import support has just landed in Rollup 0.55.0.
When testing a project that uses buble via rollup-plugin-buble, I noticed that it doesn't support dynamic import yet, resulting in the error
Looking at the rollup source code, I see that they are using acorn-dynamic-import.
This pull request therefore adds the acorn-dynamic-import plugin as done in rollup itself so that buble is able to parse code that uses dynamic import.
I've also created a small test file that fails without these changes.
Let me know if it's enought or if I should write more tests.