fix: make letConst transpilation add explicit keys when appropriate #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When letConst transpilation is on, buble renames some variables,
such as x->x$1. However, when shorthand properties are used, this
causes the property key to change.
The appropriate fix is to make those properties no longer be
shorthand, so something like { x : x$1 } is used.
This applies both to object literals and object destructuring
patterns.
The destructuring and concise property transpilation options hide
this bug, so this commit only improves the situation for use-cases
where letConst transpilation is used without those options.
mourner
approved these changes
Nov 15, 2019
src/program/BlockStatement.js
Outdated
| declaration.name = alias; | ||
| code.overwrite( | ||
| declaration.node.start, | ||
| declaration.node.end, | ||
| alias, | ||
| { storeName: true } | ||
| ); | ||
| if (declarationParent.type === 'Property' && declarationParent.shorthand) { | ||
| declarationParent.shorthand = false; | ||
| code.prependLeft(declaration.node.start, `${name}: `); |
There was a problem hiding this comment.
This should be fixed in the new commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When letConst transpilation is on, buble renames some variables, such as x->x$1. However, when shorthand properties are used, this causes the property key to change.
The appropriate fix is to make those properties no longer be shorthand, so something like
{ x : x$1 }is used.This applies both to object literals and object destructuring patterns.
The destructuring and concise property transpilation options hide this bug, so this commit only improves the situation for use-cases where letConst transpilation is used without those options.