Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make letConst transpilation add explicit keys when appropriate #229

Merged
merged 2 commits into from
Nov 15, 2019
Merged

fix: make letConst transpilation add explicit keys when appropriate #229

merged 2 commits into from
Nov 15, 2019

Commits on Nov 15, 2019

  1. fix: make letConst transpilation add explicit keys when appropriate 

    When letConst transpilation is on, buble renames some variables,
such as x->x$1. However, when shorthand properties are used, this
causes the property key to change.
The appropriate fix is to make those properties no longer be
shorthand, so something like { x : x$1 } is used.
This applies both to object literals and object destructuring
patterns.

The destructuring and concise property transpilation options hide
this bug, so this commit only improves the situation for use-cases
where letConst transpilation is used without those options.
    @luisreis-jscr
    luisreis-jscr committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    e1aa483 View commit details
    Browse the repository at this point in the history

  2. style: fix improper formatting

    @luiscubal
    luiscubal committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    f5f5e20 View commit details
    Browse the repository at this point in the history