Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup Endpoints #231

Merged
merged 7 commits into from
Oct 7, 2019
Merged

Signup Endpoints #231

merged 7 commits into from
Oct 7, 2019

Conversation

renatonascalves
Copy link
Member

fixes #150

@renatonascalves renatonascalves self-assigned this Aug 25, 2019
imath
imath reviewed Aug 25, 2019
View reviewed changes
Copy link
Member

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, so close to beta1 release, this should be moved to 0.2.0 milestone 😉

includes/bp-signup/classes/class-bp-rest-signup-endpoint.php Show resolved Hide resolved
@renatonascalves
Copy link
Member Author

@imath This is ready for your code review! :)

imath
imath approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@renatonascalves renatonascalves merged commit 562676d into master Oct 7, 2019
@renatonascalves renatonascalves deleted the signup branch October 7, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imath imath imath approved these changes

Assignees

@renatonascalves renatonascalves

Labels
Component: Signup enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signup Endpoints
2 participants
@renatonascalves @imath