Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rtMedia plugin appears to cause an error notice to be thrown #28

Closed
emaralive opened this issue Nov 10, 2023 · 4 comments · Fixed by #29
Closed

The rtMedia plugin appears to cause an error notice to be thrown #28

emaralive opened this issue Nov 10, 2023 · 4 comments · Fixed by #29
Assignees

Comments

@emaralive
Copy link

The environment at the time:

WP 6.4.1
BP 12.0.0.beta4
PHP 7.4.33
rtMedia plugin 4.6.15
Classic plugin 1.1.0

Active components:

Community Members, Extended Profiles, Account Settings, Friend Connections, Private Messaging, Activity Streams, Notifications, User Groups, Site Tracking

Active template pack:

BuddyPress Nouveau

Parent theme:

Twenty Eleven

Note: Any WP branch compatiple with BP 12.0.0, either BP template pack, and any compatible WP theme is sufficient to replicate this issue.

The key factors are "User Groups" enabled, the rtMedia plugin active and visiting a group page, e.g., site.url/groups/name_of_group/, will result with the following error notice to be thrown:

Notice: Trying to get property 'inc_dir' of non-object in /wp-content/plugins/bp-classic/inc/core/widgets.php on line 122

Offhand, it looks like there is an issue with timing of when the property "inc_dir" is available. Additionally, while on group page any cause for a page refresh, e.g, clicking on a group menu item, causes the same error to be thrown.

@imath imath self-assigned this Nov 10, 2023
@imath
Copy link
Member

imath commented Nov 10, 2023

Thanks a lot for your report. Looking at it asap.

@imath
Copy link
Member

imath commented Nov 11, 2023

This is what I get:
[11-Nov-2023 10:58:55 UTC] PHP Warning: Attempt to read property "inc_dir" on bool in /.../bp-classic/inc/core/widgets.php on line 122

I confirm it's not happening without rtMedia active. But I believe it's revealing a BP Classic issue. We should only check if the current BuddyPress version is 12.0 or up once. I see we are doing it each time bp_classic() is called.

I'll submit a PR asap.

@imath
Copy link
Member

imath commented Nov 11, 2023

Actually after digging more into it, rtMedia is doing something wrong. I just reported an issue about it:
rtCamp/rtMedia#2009

@emaralive
Copy link
Author

I see, OK sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants